Re: [PATCH v3 25/37] mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc

2017-03-30 Thread Boris Brezillon
On Thu, 30 Mar 2017 15:46:11 +0900 Masahiro Yamada wrote: > /* > * sends a pipeline command operation to the controller. See the Denali NAND > * controller's user guide for more information (section 4.2.3.6). > @@ -824,7 +856,13 @@ static void denali_select_chip(struct mtd_info *mtd, int >

[PATCH v3 25/37] mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc

2017-03-29 Thread Masahiro Yamada
The NAND_CMD_SET_FEATURES support is missing from denali_cmdfunc(). This is needed for nand_onfi_set_features(). Besides, we see /* TODO: Read OOB data */ comment line. It would be possible to add more commands along with the current implementation, but having ->cmd_ctrl() seems a better approach