Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-11 Thread Joerg Roedel
On Thu, Jun 04, 2020 at 07:59:33AM -0700, Sean Christopherson wrote: > But SEV already broke it, no? True, but with SEV-ES is can be fixed again, and all SEV hardware also supports SEV-ES. Regards, Joerg

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 12:15:02PM +0200, Joerg Roedel wrote: > On Wed, Jun 03, 2020 at 04:07:16PM -0700, Sean Christopherson wrote: > > On Wed, Jun 03, 2020 at 04:23:25PM +0200, Joerg Roedel wrote: > > > User-space can also cause IOIO #VC exceptions, and user-space can be > > > 32-bit legacy code

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-04 Thread Joerg Roedel
On Wed, Jun 03, 2020 at 04:07:16PM -0700, Sean Christopherson wrote: > On Wed, Jun 03, 2020 at 04:23:25PM +0200, Joerg Roedel wrote: > > User-space can also cause IOIO #VC exceptions, and user-space can be > > 32-bit legacy code with segments, so es_base has to be taken into > > account. > > Is

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-03 Thread Sean Christopherson
On Wed, Jun 03, 2020 at 04:23:25PM +0200, Joerg Roedel wrote: > > > + */ > > > + io_bytes = (exit_info_1 >> 4) & 0x7; > > > + ghcb_count = sizeof(ghcb->shared_buffer) / io_bytes; > > > + > > > + op_count= (exit_info_1 & IOIO_REP) ? regs->cx : 1; > > > +

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-03 Thread Joerg Roedel
Hi Jean, On Tue, May 19, 2020 at 11:20:55PM -0700, Sean Christopherson wrote: > On Tue, Apr 28, 2020 at 05:16:35PM +0200, Joerg Roedel wrote: > > + /* > > +* For the string variants with rep prefix the amount of in/out > > +* operations per #VC exception is

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-03 Thread Joerg Roedel
On Sat, May 16, 2020 at 09:57:14AM +0200, Borislav Petkov wrote: > Just a reminder so that this doesn't get lost: > > On Tue, Apr 28, 2020 at 05:16:35PM +0200, Joerg Roedel wrote: > > + if (exit_info_1 & IOIO_TYPE_STR) { > > + int df = (regs->flags & X86_EFLAGS_DF) ? -1 : 1; > > ...

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-05-20 Thread Sean Christopherson
On Tue, Apr 28, 2020 at 05:16:35PM +0200, Joerg Roedel wrote: > From: Tom Lendacky > > Add support for decoding and handling #VC exceptions for IOIO events. > > Signed-off-by: Tom Lendacky > [ jroe...@suse.de: Adapted code to #VC handling framework ] > Co-developed-by: Joerg Roedel >

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-05-16 Thread Borislav Petkov
Just a reminder so that this doesn't get lost: On Tue, Apr 28, 2020 at 05:16:35PM +0200, Joerg Roedel wrote: > + if (exit_info_1 & IOIO_TYPE_STR) { > + int df = (regs->flags & X86_EFLAGS_DF) ? -1 : 1; ... > + > + if (!(exit_info_1 & IOIO_TYPE_IN)) { > +

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-05-13 Thread Borislav Petkov
On Tue, Apr 28, 2020 at 05:16:35PM +0200, Joerg Roedel wrote: > From: Tom Lendacky > > Add support for decoding and handling #VC exceptions for IOIO events. > > Signed-off-by: Tom Lendacky > [ jroe...@suse.de: Adapted code to #VC handling framework ] > Co-developed-by: Joerg Roedel >

[PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-04-28 Thread Joerg Roedel
From: Tom Lendacky Add support for decoding and handling #VC exceptions for IOIO events. Signed-off-by: Tom Lendacky [ jroe...@suse.de: Adapted code to #VC handling framework ] Co-developed-by: Joerg Roedel Signed-off-by: Joerg Roedel --- arch/x86/boot/compressed/sev-es.c | 32 +