Re: [PATCH v3 3/3] HID: core: fix dmesg flooding if report field larger than 32bit

2019-09-18 Thread Joshua Clayton
Thanks! It means a lot to have this accepted. I actually started working on it, thinking "how hard can it be to increase the size of a data structure"? It only has to be forward compatible anyway. My gut feeling is the existing code is working way too hard to do what should be a memcpy, and the

Re: [PATCH v3 3/3] HID: core: fix dmesg flooding if report field larger than 32bit

2019-09-18 Thread Benjamin Tissoires
On Thu, Aug 29, 2019 at 1:26 AM Joshua Clayton wrote: > > ping? > I'd love to see this get in. > with distro kernel I have effectively no dmesg due to this issue Apologies for the delay. I really thought we should find a better way of fixing this, until I got a laptop affected by it. This

Re: [PATCH v3 3/3] HID: core: fix dmesg flooding if report field larger than 32bit

2019-08-28 Thread Joshua Clayton
ping? I'd love to see this get in. with distro kernel I have effectively no dmesg due to this issue On Mon, Aug 12, 2019 at 9:20 AM wrote: > > From: Joshua Clayton > > Only warn once of oversize hid report value field > > On HP spectre x360 convertible the message: > hid-sensor-hub

[PATCH v3 3/3] HID: core: fix dmesg flooding if report field larger than 32bit

2019-08-12 Thread stillcompiling
From: Joshua Clayton Only warn once of oversize hid report value field On HP spectre x360 convertible the message: hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2) is continually printed many times per second, crowding out all else. Protect dmesg