Re: [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-22 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 07:13:32PM -0500, Alex G. wrote: > I think it's clearer if this is explained in a comment. That it doesn't > break anything, and we're okay this applies to all hotplug ports, even those > that are not in front of an NVMe backplane. I agree.

Re: [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-21 Thread Alex G.
On 10/21/19 1:19 PM, Stuart Hayes wrote: On 10/21/19 8:47 AM, Mika Westerberg wrote: On Thu, Oct 17, 2019 at 03:32:56PM -0400, Stuart Hayes wrote: Some systems have in-band presence detection disabled for hot-plug PCI slots, but do not report this in the slot capabilities 2 (SLTCAP2) register

Re: [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-21 Thread Stuart Hayes
On 10/21/19 8:47 AM, Mika Westerberg wrote: > On Thu, Oct 17, 2019 at 03:32:56PM -0400, Stuart Hayes wrote: >> Some systems have in-band presence detection disabled for hot-plug PCI >> slots, but do not report this in the slot capabilities 2 (SLTCAP2) register. >> On these systems, presence dete

Re: [PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-21 Thread Mika Westerberg
On Thu, Oct 17, 2019 at 03:32:56PM -0400, Stuart Hayes wrote: > Some systems have in-band presence detection disabled for hot-plug PCI > slots, but do not report this in the slot capabilities 2 (SLTCAP2) register. > On these systems, presence detect can become active well after the link is > report

[PATCH v3 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-17 Thread Stuart Hayes
Some systems have in-band presence detection disabled for hot-plug PCI slots, but do not report this in the slot capabilities 2 (SLTCAP2) register. On these systems, presence detect can become active well after the link is reported to be active, which can cause the slots to be disabled after a devi