Re: [PATCH v3 3/3] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb()

2014-06-30 Thread Tejun Heo
Hello, Li. I applied the three patches with some updates (mostly comments). Dynamic root management is turning out to be pretty ugly but I think we can clean it up a bit. On Mon, Jun 30, 2014 at 11:50:59AM +0800, Li Zefan wrote: > @@ -1790,6 +1795,17 @@ out_free: > dentry = kernfs_mount(fs_

Re: [PATCH v3 3/3] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb()

2014-06-30 Thread Tejun Heo
Applied to cgroup/for-3.16-fixes with minor updates. Thanks. -- 8< -- >From 3a32bd72d77058d768dbb38183ad517f720dd1bc Mon Sep 17 00:00:00 2001 From: Li Zefan Date: Mon, 30 Jun 2014 11:50:59 +0800 Subject: [PATCH 3/3] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb() We've co

[PATCH v3 3/3] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb()

2014-06-29 Thread Li Zefan
We've converted cgroup to kernfs so cgroup won't be intertwined with vfs objects and locking, but there are dark areas. Run two instances of this script concurrently: for ((; ;)) { mount -t cgroup -o cpuacct xxx /cgroup umount /cgroup } After a while, I saw two mount