On Mon, Mar 29, 2021 at 8:54 PM Andy Shevchenko
wrote:
>
> On Sat, Mar 06, 2021 at 07:36:30PM +0530, Syed Nayyar Waris wrote:
> > This patch reimplements the xgpio_set_multiple() function in
> > drivers/gpio/gpio-xilinx.c to use the new generic functions:
> > bitmap_get_value() and
On Fri, Mar 26, 2021 at 11:27 PM Andy Shevchenko
wrote:
>
> On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris wrote:
> >
> > This patch reimplements the xgpio_set_multiple() function in
> > drivers/gpio/gpio-xilinx.c to use the new generic functions:
> > bitmap_get_value() and bitmap_set_value().
On Sat, Mar 27, 2021 at 10:05 PM Andy Shevchenko
wrote:
>
> On Sat, Mar 27, 2021 at 2:02 PM William Breathitt Gray
> wrote:
> > On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> > > On Saturday, March 27, 2021, Syed Nayyar Waris
> > > wrote:
> > > > On Fri, Mar 26, 2021 at
On Mon, Mar 29, 2021 at 8:54 PM Andy Shevchenko
wrote:
>
> On Sat, Mar 06, 2021 at 07:36:30PM +0530, Syed Nayyar Waris wrote:
> > This patch reimplements the xgpio_set_multiple() function in
> > drivers/gpio/gpio-xilinx.c to use the new generic functions:
> > bitmap_get_value() and
; Zhang Rui ; Daniel
> > > Lezcano ; Amit Kucheria
> > > ; Linux-Arch ;
> > > linux-gpio ; LKML > > ker...@vger.kernel.org>; arm-soc ;
> > > linux-pm ; Srinivas Goud
> > > Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic
> > &
henko
> > ; William Breathitt Gray
> > ; Arnd Bergmann ; Robert
> > Richter ; Linus Walleij ;
> > Masahiro Yamada ; Andrew Morton
> > ; Zhang Rui ; Daniel
> > Lezcano ; Amit Kucheria
> > ; Linux-Arch ;
> > linux-gpio ; LKML > ker...@vger.kernel.org
> Masahiro Yamada ; Andrew Morton
> ; Zhang Rui ; Daniel
> Lezcano ; Amit Kucheria
> ; Linux-Arch ;
> linux-gpio ; LKML ker...@vger.kernel.org>; arm-soc ;
> linux-pm ; Srinivas Goud
> Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and
> _set_
On Sat, Mar 06, 2021 at 07:36:30PM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover,
On Sat, Mar 27, 2021 at 2:02 PM William Breathitt Gray
wrote:
> On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Syed Nayyar Waris wrote:
> > > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > > wrote:
> > > > On Sat, Mar 6, 2021 at 4:08 PM
On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> On Saturday, March 27, 2021, Syed Nayyar Waris wrote:
>
> > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > wrote:
> > >
> > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris
> > wrote:
> > >
> > > > +
On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
wrote:
>
> On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris wrote:
>
> > + bitmap_set_value(old, 64, state[0], 32, 0);
> > + bitmap_set_value(old, 64, state[1], 32, 32);
>
> Isn't it effectively bitnap_from_arr32() ?
>
> > +
On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris wrote:
> + bitmap_set_value(old, 64, state[0], 32, 0);
> + bitmap_set_value(old, 64, state[1], 32, 32);
Isn't it effectively bitnap_from_arr32() ?
> + bitmap_set_value(new, 64, state[0], 32, 0);
> + bitmap_set_value(new,
On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris wrote:
>
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover, instead
On Mon, Mar 8, 2021 at 8:13 AM Michal Simek wrote:
>
>
>
> On 3/6/21 3:06 PM, Syed Nayyar Waris wrote:
> > This patch reimplements the xgpio_set_multiple() function in
> > drivers/gpio/gpio-xilinx.c to use the new generic functions:
> > bitmap_get_value() and bitmap_set_value(). The code is now
On 3/6/21 3:06 PM, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover, instead of looping
This patch reimplements the xgpio_set_multiple() function in
drivers/gpio/gpio-xilinx.c to use the new generic functions:
bitmap_get_value() and bitmap_set_value(). The code is now simpler
to read and understand. Moreover, instead of looping for each bit
in xgpio_set_multiple() function, now we
16 matches
Mail list logo
