Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-10 Thread Michal Hocko
On Tue 09-04-13 18:00:34, Naoya Horiguchi wrote: [...] > I rewrite the comment here, how about this? > > - if (absent || > + /* > + * We need call hugetlb_fault for both hugepages under migration > + * (in which case hugetlb_fault waits for the mig

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-09 Thread KOSAKI Motohiro
> I rewrite the comment here, how about this? > > - if (absent || > + /* > +* We need call hugetlb_fault for both hugepages under > migration > +* (in which case hugetlb_fault waits for the migration,) and > +* hwpoisoned

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-09 Thread Naoya Horiguchi
On Mon, Apr 08, 2013 at 04:57:44PM -0400, KOSAKI Motohiro wrote: > > - if (absent || > > + /* > > +* is_swap_pte test covers both is_hugetlb_entry_hwpoisoned > > +* and hugepages under migration in which case > > +* hugetlb

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-08 Thread KOSAKI Motohiro
> - if (absent || > + /* > +* is_swap_pte test covers both is_hugetlb_entry_hwpoisoned > +* and hugepages under migration in which case > +* hugetlb_fault waits for the migration and bails out > +* properly

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-08 Thread Naoya Horiguchi
On Fri, Apr 05, 2013 at 02:59:43PM -0400, KOSAKI Motohiro wrote: > (4/3/13 2:35 PM), Naoya Horiguchi wrote: > > With applying the previous patch "hugetlbfs: stop setting VM_DONTDUMP in > > initializing vma(VM_HUGETLB)" to reenable hugepage coredump, if a memory > > error happens on a hugepage and t

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-05 Thread KOSAKI Motohiro
(4/3/13 2:35 PM), Naoya Horiguchi wrote: > With applying the previous patch "hugetlbfs: stop setting VM_DONTDUMP in > initializing vma(VM_HUGETLB)" to reenable hugepage coredump, if a memory > error happens on a hugepage and the affected processes try to access > the error hugepage, we hit VM_BUG_O

Re: [PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-03 Thread Rik van Riel
On 04/03/2013 02:35 PM, Naoya Horiguchi wrote: With applying the previous patch "hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)" to reenable hugepage coredump, if a memory error happens on a hugepage and the affected processes try to access the error hugepage, we hit VM_BUG_O

[PATCH v3 3/3] hugetlbfs: add swap entry check in follow_hugetlb_page()

2013-04-03 Thread Naoya Horiguchi
With applying the previous patch "hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)" to reenable hugepage coredump, if a memory error happens on a hugepage and the affected processes try to access the error hugepage, we hit VM_BUG_ON(atomic_read(&page->_count) <= 0) in get_page().