Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-13 Thread Jonathan Cameron
On Thu, 11 Oct 2018 12:35:18 +0800 Song Qiang wrote: > On 2018年10月07日 23:44, Jonathan Cameron wrote: > > On Tue, 2 Oct 2018 22:38:12 +0800 > > Song Qiang wrote: > > > >> PNI RM3100 is a high resolution, large signal immunity magnetometer, > >> composed of 3 single sensors and a processing

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-13 Thread Jonathan Cameron
On Thu, 11 Oct 2018 12:35:18 +0800 Song Qiang wrote: > On 2018年10月07日 23:44, Jonathan Cameron wrote: > > On Tue, 2 Oct 2018 22:38:12 +0800 > > Song Qiang wrote: > > > >> PNI RM3100 is a high resolution, large signal immunity magnetometer, > >> composed of 3 single sensors and a processing

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-10 Thread Song Qiang
On 2018年10月07日 23:44, Jonathan Cameron wrote: On Tue, 2 Oct 2018 22:38:12 +0800 Song Qiang wrote: PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: -

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-10 Thread Song Qiang
On 2018年10月07日 23:44, Jonathan Cameron wrote: On Tue, 2 Oct 2018 22:38:12 +0800 Song Qiang wrote: PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: -

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-07 Thread Jonathan Cameron
On Tue, 2 Oct 2018 22:38:12 +0800 Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with a MagI2C > interface. > > Following functions are available: > - Single-shot measurement from >

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-07 Thread Jonathan Cameron
On Tue, 2 Oct 2018 22:38:12 +0800 Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with a MagI2C > interface. > > Following functions are available: > - Single-shot measurement from >

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-07 Thread Jonathan Cameron
On Wed, 3 Oct 2018 09:42:14 +0800 Phil Reid wrote: > G'day Song, Hi Phil. Good point below. One general thing though, if you could possibly crop down a review email when you are addressing one specific point it would be very much appreciated! Saves everyone else scrolling and if they have a

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-07 Thread Jonathan Cameron
On Wed, 3 Oct 2018 09:42:14 +0800 Phil Reid wrote: > G'day Song, Hi Phil. Good point below. One general thing though, if you could possibly crop down a review email when you are addressing one specific point it would be very much appreciated! Saves everyone else scrolling and if they have a

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-02 Thread Phil Reid
G'day Song, Noticed a one more thing below On 2/10/2018 10:38 PM, Song Qiang wrote: PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: - Single-shot measurement

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-02 Thread Phil Reid
G'day Song, Noticed a one more thing below On 2/10/2018 10:38 PM, Song Qiang wrote: PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: - Single-shot measurement

[PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-02 Thread Song Qiang
PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: - Single-shot measurement from /sys/bus/iio/devices/iio:deviceX/in_magn_{axis}_raw - Triggerd buffer

[PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-02 Thread Song Qiang
PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with a MagI2C interface. Following functions are available: - Single-shot measurement from /sys/bus/iio/devices/iio:deviceX/in_magn_{axis}_raw - Triggerd buffer