Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Ingi Kim
Hi Jacek, Thanks for the review I can make this code better :) On 2015년 10월 26일 19:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. I've found a few minor issues, please > refer to my comments below. > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This patch adds device driver

Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Jacek Anaszewski
Hi Ingi, Thanks for the update. I've found a few minor issues, please refer to my comments below. On 10/23/2015 07:48 AM, Ingi Kim wrote: This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by:

Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Jacek Anaszewski
Hi Ingi, Thanks for the update. I've found a few minor issues, please refer to my comments below. On 10/23/2015 07:48 AM, Ingi Kim wrote: This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by:

Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Ingi Kim
Hi Jacek, Thanks for the review I can make this code better :) On 2015년 10월 26일 19:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. I've found a few minor issues, please > refer to my comments below. > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This patch adds device driver

[PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-22 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c | 314

[PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-22 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 +