Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-20 Thread Joel Fernandes
On Wed, Apr 17, 2019 at 05:16:18PM +0200, Jessica Yu wrote: > +++ Steven Rostedt [10/04/19 20:44 -0400]: > > On Wed, 10 Apr 2019 16:29:02 -0400 > > Joel Fernandes wrote: > > > > > The srcu structure pointer array is modified at module load time because > > > the > > > array is fixed up by the mo

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-17 Thread Paul E. McKenney
On Wed, Apr 17, 2019 at 05:16:18PM +0200, Jessica Yu wrote: > +++ Steven Rostedt [10/04/19 20:44 -0400]: > >On Wed, 10 Apr 2019 16:29:02 -0400 > >Joel Fernandes wrote: > > > >>The srcu structure pointer array is modified at module load time because the > >>array is fixed up by the module loader at

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-17 Thread Jessica Yu
+++ Steven Rostedt [10/04/19 20:44 -0400]: On Wed, 10 Apr 2019 16:29:02 -0400 Joel Fernandes wrote: The srcu structure pointer array is modified at module load time because the array is fixed up by the module loader at load-time with the final locations of the tracepoints right? Basically rel

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-11 Thread Joel Fernandes
On Thu, Apr 11, 2019 at 09:19:55AM -0400, Steven Rostedt wrote: > On Thu, 11 Apr 2019 04:21:06 -0400 > Joel Fernandes wrote: > > > Patch 2/3 and 3/3 would not be nececessary if this works out. 1/3 may be a > > nice clean up but is not something urgent and we could do that in the future > > if nee

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-11 Thread Paul E. McKenney
On Thu, Apr 11, 2019 at 04:21:06AM -0400, Joel Fernandes wrote: > On Wed, Apr 10, 2019 at 08:44:01PM -0400, Steven Rostedt wrote: > > On Wed, 10 Apr 2019 16:29:02 -0400 > > Joel Fernandes wrote: > > > > > The srcu structure pointer array is modified at module load time because > > > the > > > ar

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-11 Thread Steven Rostedt
On Thu, 11 Apr 2019 04:21:06 -0400 Joel Fernandes wrote: > Patch 2/3 and 3/3 would not be nececessary if this works out. 1/3 may be a > nice clean up but is not something urgent and we could do that in the future > if needed. Well, jump_labels is "special" because it requires sorting the RO data

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-11 Thread Joel Fernandes
On Wed, Apr 10, 2019 at 08:44:01PM -0400, Steven Rostedt wrote: > On Wed, 10 Apr 2019 16:29:02 -0400 > Joel Fernandes wrote: > > > The srcu structure pointer array is modified at module load time because the > > array is fixed up by the module loader at load-time with the final locations > > of t

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 16:29:02 -0400 Joel Fernandes wrote: > The srcu structure pointer array is modified at module load time because the > array is fixed up by the module loader at load-time with the final locations > of the tracepoints right? Basically relocation fixups. At compile time, I > bel

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Joel Fernandes
On Wed, Apr 10, 2019 at 04:11:12PM -0400, Steven Rostedt wrote: > On Wed, 10 Apr 2019 15:57:08 -0400 > "Joel Fernandes (Google)" wrote: > > > This series hardens the tracepoints in modules by making the array of > > pointers referring to the tracepoints as read-only. This array is needed > > duri

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 15:57:08 -0400 "Joel Fernandes (Google)" wrote: > This series hardens the tracepoints in modules by making the array of > pointers referring to the tracepoints as read-only. This array is needed > during module unloading to verify that the tracepoint is quiescent. > There is n

[PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Joel Fernandes (Google)
This series hardens the tracepoints in modules by making the array of pointers referring to the tracepoints as read-only. This array is needed during module unloading to verify that the tracepoint is quiescent. There is no reason for the array to be to be writable after init, and can cause security