Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
On Tue, Feb 24, 2015 at 09:30:21PM +1300, Felix Fietkau wrote: > On 2015-02-24 21:27, Brian Norris wrote: > > On Tue, Feb 24, 2015 at 09:20:31PM +1300, Felix Fietkau wrote: > >> On 2015-02-24 21:07, Brian Norris wrote: > >> > OK let's drop this patch from the series. At best, we could just do > >>

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Felix Fietkau
t;> Sent: Wednesday, November 26, 2014 5:21:47 AM >> >> Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index >> >> to >> >> partition size >> >> >> >> > On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wr

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
> >> Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to > >> partition size > >> > >> > On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: > >> > > - dev->mtd.size = dev->blkdev->bd_inode->i_size &

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Felix Fietkau
On 2015-02-24 21:07, Brian Norris wrote: > On Wed, Nov 26, 2014 at 08:19:32AM -0500, Rodrigo Freire wrote: >> From: "Brian Norris" >> Sent: Wednesday, November 26, 2014 5:21:47 AM >> Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to >>

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
On Wed, Nov 26, 2014 at 08:19:32AM -0500, Rodrigo Freire wrote: > From: "Brian Norris" > Sent: Wednesday, November 26, 2014 5:21:47 AM > Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to > partition size > > > On Sun, Nov 09, 2014 at 0

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Felix Fietkau
5:21:47 AM Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: - dev-mtd.size = dev-blkdev-bd_inode-i_size PAGE_MASK; + dev-mtd.size = dev-blkdev-bd_inode-i_size

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Felix Fietkau
On 2015-02-24 21:07, Brian Norris wrote: On Wed, Nov 26, 2014 at 08:19:32AM -0500, Rodrigo Freire wrote: From: Brian Norris computersforpe...@gmail.com Sent: Wednesday, November 26, 2014 5:21:47 AM Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
On Tue, Feb 24, 2015 at 09:30:21PM +1300, Felix Fietkau wrote: On 2015-02-24 21:27, Brian Norris wrote: On Tue, Feb 24, 2015 at 09:20:31PM +1300, Felix Fietkau wrote: On 2015-02-24 21:07, Brian Norris wrote: OK let's drop this patch from the series. At best, we could just do something

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
On Wed, Nov 26, 2014 at 08:19:32AM -0500, Rodrigo Freire wrote: From: Brian Norris computersforpe...@gmail.com Sent: Wednesday, November 26, 2014 5:21:47 AM Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size On Sun, Nov 09, 2014 at 07:23:12AM -0500

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2015-02-24 Thread Brian Norris
] mtd: block2mtd: Removes PAGE_MASK as a index to partition size On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: - dev-mtd.size = dev-blkdev-bd_inode-i_size PAGE_MASK; + dev-mtd.size = dev-blkdev-bd_inode-i_size ~(erase_size - 1); You never guaranteed

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-26 Thread Rodrigo Freire
From: "Brian Norris" Sent: Wednesday, November 26, 2014 5:21:47 AM Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size > On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: > > PAGE_MASK is no longer needed with the new term

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-26 Thread Rodrigo Freire
From: Brian Norris computersforpe...@gmail.com Sent: Wednesday, November 26, 2014 5:21:47 AM Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: PAGE_MASK is no longer needed with the new

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-25 Thread Brian Norris
On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: > From: Felix Fietkau > > mtd: block2mtd: Removes PAGE_MASK as a index to partition size You don't need to repeat the subject here. > > PAGE_MASK is no longer needed with the new term. This isn't too descriptive. What you

Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-25 Thread Brian Norris
On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote: From: Felix Fietkau n...@openwrt.org mtd: block2mtd: Removes PAGE_MASK as a index to partition size You don't need to repeat the subject here. PAGE_MASK is no longer needed with the new term. This isn't too descriptive. What

[PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-09 Thread Rodrigo Freire
From: Felix Fietkau mtd: block2mtd: Removes PAGE_MASK as a index to partition size PAGE_MASK is no longer needed with the new term. This patch keeps the device size aligned with the erase_size. Signed-off-by: Felix Fietkau Signed-off-by: Rodrigo Freire Signed-off-by: Herton Krzesinski ---

[PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size

2014-11-09 Thread Rodrigo Freire
From: Felix Fietkau n...@openwrt.org mtd: block2mtd: Removes PAGE_MASK as a index to partition size PAGE_MASK is no longer needed with the new term. This patch keeps the device size aligned with the erase_size. Signed-off-by: Felix Fietkau n...@openwrt.org Signed-off-by: Rodrigo Freire