Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-03-01 Thread Suman Anna
On 03/01/2016 05:55 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 01 March 2016 01:55 PM, Paul Walmsley wrote: >> >> Folks, the following is what I've queued for this. > > Thanks Paul. > > Bjorn, > > With this patch merged, enabling pci-dra7xx won't result in system freeze > anymore. I

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-03-01 Thread Bjorn Helgaas
On Tue, Mar 01, 2016 at 05:25:56PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 01 March 2016 01:55 PM, Paul Walmsley wrote: > > > > Folks, the following is what I've queued for this. > > Thanks Paul. > > Bjorn, > > With this patch merged, enabling pci-dra7xx won't result in syste

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-03-01 Thread Kishon Vijay Abraham I
Hi, On Tuesday 01 March 2016 01:55 PM, Paul Walmsley wrote: > > Folks, the following is what I've queued for this. Thanks Paul. Bjorn, With this patch merged, enabling pci-dra7xx won't result in system freeze anymore. I can send a patch to revert depends on BROKEN. Thanks Kishon > > > - Pa

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-03-01 Thread Paul Walmsley
Folks, the following is what I've queued for this. - Paul From: Sekhar Nori Date: Thu, 18 Feb 2016 16:49:56 +0530 Subject: [PATCH] ARM: DRA7: hwmod: Add custom reset handler for PCIeSS Add a custom reset handler for DRA7x PCIeSS. This handler is required to deassert PCIe hardreset lines afte

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-23 Thread Kishon Vijay Abraham I
Hi Paul, On Tuesday 23 February 2016 11:58 PM, Paul Walmsley wrote: > Kishon > > On Tue, 23 Feb 2016, Kishon Vijay Abraham I wrote: > >> On Monday 22 February 2016 03:25 PM, Kishon Vijay Abraham I wrote: >>> On Monday 22 February 2016 12:01 PM, Paul Walmsley wrote: On Mon, 22 Feb 2016, Kish

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-23 Thread Paul Walmsley
Kishon On Tue, 23 Feb 2016, Kishon Vijay Abraham I wrote: > On Monday 22 February 2016 03:25 PM, Kishon Vijay Abraham I wrote: > > On Monday 22 February 2016 12:01 PM, Paul Walmsley wrote: > >> On Mon, 22 Feb 2016, Kishon Vijay Abraham I wrote: > >>> On Thursday 18 February 2016 07:51 PM, Sekhar

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-23 Thread Kishon Vijay Abraham I
Hi Paul, On Monday 22 February 2016 03:25 PM, Kishon Vijay Abraham I wrote: > Hi Paul, > > On Monday 22 February 2016 12:01 PM, Paul Walmsley wrote: >> Kishon, >> >> On Mon, 22 Feb 2016, Kishon Vijay Abraham I wrote: >> >>> Sekhar, >>> >>> On Thursday 18 February 2016 07:51 PM, Sekhar Nori wrote:

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-22 Thread Kishon Vijay Abraham I
Hi Paul, On Monday 22 February 2016 12:01 PM, Paul Walmsley wrote: > Kishon, > > On Mon, 22 Feb 2016, Kishon Vijay Abraham I wrote: > >> Sekhar, >> >> On Thursday 18 February 2016 07:51 PM, Sekhar Nori wrote: >>> On Friday 12 February 2016 10:50 PM, Suman Anna wrote: Sekhar, Will you b

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-21 Thread Paul Walmsley
Kishon, On Mon, 22 Feb 2016, Kishon Vijay Abraham I wrote: > Sekhar, > > On Thursday 18 February 2016 07:51 PM, Sekhar Nori wrote: > > On Friday 12 February 2016 10:50 PM, Suman Anna wrote: > >> Sekhar, > >> Will you be following up with above suggestion since Kishon is gonna be > >> out? > >

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-21 Thread Kishon Vijay Abraham I
Sekhar, On Thursday 18 February 2016 07:51 PM, Sekhar Nori wrote: > On Friday 12 February 2016 10:50 PM, Suman Anna wrote: >> Sekhar, >> Will you be following up with above suggestion since Kishon is gonna be out? > > Alright, noticed this action for me :) Went through the thread, and > looks li

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-18 Thread Suman Anna
On 02/18/2016 11:23 AM, Paul Walmsley wrote: > > On Thu, 18 Feb 2016, Sekhar Nori wrote: > >> On Friday 12 February 2016 10:50 PM, Suman Anna wrote: >>> Sekhar, >>> Will you be following up with above suggestion since Kishon is gonna be out? >> >> Alright, noticed this action for me :) Went throu

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-18 Thread Paul Walmsley
On Thu, 18 Feb 2016, Sekhar Nori wrote: > On Friday 12 February 2016 10:50 PM, Suman Anna wrote: > > Sekhar, > > Will you be following up with above suggestion since Kishon is gonna be out? > > Alright, noticed this action for me :) Went through the thread, and > looks like this is what we want

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-18 Thread Sekhar Nori
On Friday 12 February 2016 10:50 PM, Suman Anna wrote: > Sekhar, > Will you be following up with above suggestion since Kishon is gonna be out? Alright, noticed this action for me :) Went through the thread, and looks like this is what we want to see? Thanks, Sekhar ---8<--- >From e3ba368f2235e

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-12 Thread Suman Anna
Kishon, On 02/12/2016 12:49 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 12 February 2016 12:57 AM, Paul Walmsley wrote: >> Hi Kishon, Suman, >> >> On Wed, 10 Feb 2016, Kishon Vijay Abraham I wrote: >> >>> On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: On 02/09/2016 01:36

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-11 Thread Kishon Vijay Abraham I
Hi Suman, On Friday 12 February 2016 02:13 AM, Suman Anna wrote: > On 02/09/2016 11:38 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: >>> Hi Paul, >>> >>> On 02/09/2016 01:36 PM, Paul Walmsley wrote: Hi Suman On Tue, 9 Feb 2

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-11 Thread Kishon Vijay Abraham I
Hi, On Friday 12 February 2016 12:57 AM, Paul Walmsley wrote: > Hi Kishon, Suman, > > On Wed, 10 Feb 2016, Kishon Vijay Abraham I wrote: > >> On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: >>> On 02/09/2016 01:36 PM, Paul Walmsley wrote: On Tue, 9 Feb 2016, Suman Anna wrote:

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-11 Thread Suman Anna
On 02/11/2016 01:27 PM, Paul Walmsley wrote: > Hi Kishon, Suman, > > On Wed, 10 Feb 2016, Kishon Vijay Abraham I wrote: > >> On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: >>> On 02/09/2016 01:36 PM, Paul Walmsley wrote: On Tue, 9 Feb 2016, Suman Anna wrote: > On 02/09/2016 02

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-11 Thread Suman Anna
On 02/09/2016 11:38 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: >> Hi Paul, >> >> On 02/09/2016 01:36 PM, Paul Walmsley wrote: >>> Hi Suman >>> >>> On Tue, 9 Feb 2016, Suman Anna wrote: >>> On 02/09/2016 02:49 AM, Paul Walmsley wrote:

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-11 Thread Paul Walmsley
Hi Kishon, Suman, On Wed, 10 Feb 2016, Kishon Vijay Abraham I wrote: > On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: > > On 02/09/2016 01:36 PM, Paul Walmsley wrote: > >> On Tue, 9 Feb 2016, Suman Anna wrote: > >>> On 02/09/2016 02:49 AM, Paul Walmsley wrote: > On Mon, 8 Feb 2016

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 February 2016 07:12 AM, Suman Anna wrote: > Hi Paul, > > On 02/09/2016 01:36 PM, Paul Walmsley wrote: >> Hi Suman >> >> On Tue, 9 Feb 2016, Suman Anna wrote: >> >>> On 02/09/2016 02:49 AM, Paul Walmsley wrote: On Mon, 8 Feb 2016, Suman Anna wrote: > On 02/07/2016 08:

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Kishon Vijay Abraham I
On Wednesday 10 February 2016 01:06 AM, Paul Walmsley wrote: > Hi Suman > > On Tue, 9 Feb 2016, Suman Anna wrote: > >> On 02/09/2016 02:49 AM, Paul Walmsley wrote: >>> On Mon, 8 Feb 2016, Suman Anna wrote: On 02/07/2016 08:48 PM, Paul Walmsley wrote: > On Tue, 2 Feb 2016, Kishon Vijay

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Suman Anna
Hi Paul, On 02/09/2016 01:36 PM, Paul Walmsley wrote: > Hi Suman > > On Tue, 9 Feb 2016, Suman Anna wrote: > >> On 02/09/2016 02:49 AM, Paul Walmsley wrote: >>> On Mon, 8 Feb 2016, Suman Anna wrote: On 02/07/2016 08:48 PM, Paul Walmsley wrote: > On Tue, 2 Feb 2016, Kishon Vijay Abraham

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Paul Walmsley
Hi Suman On Tue, 9 Feb 2016, Suman Anna wrote: > On 02/09/2016 02:49 AM, Paul Walmsley wrote: > > On Mon, 8 Feb 2016, Suman Anna wrote: > >> On 02/07/2016 08:48 PM, Paul Walmsley wrote: > >>> On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: > >>> > Paul, what do you think is the best way f

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Suman Anna
Hi Paul, On 02/09/2016 02:49 AM, Paul Walmsley wrote: > On Mon, 8 Feb 2016, Suman Anna wrote: > >> On 02/07/2016 08:48 PM, Paul Walmsley wrote: >>> On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: >>> Paul, what do you think is the best way forward to perform reset? >>> >>> Many of the IP b

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-09 Thread Paul Walmsley
On Mon, 8 Feb 2016, Suman Anna wrote: > On 02/07/2016 08:48 PM, Paul Walmsley wrote: > > On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: > > > >> Paul, what do you think is the best way forward to perform reset? > > > > Many of the IP blocks with PRM hardreset lines are processor IP blocks. >

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-08 Thread Suman Anna
Hi Paul, On 02/07/2016 08:48 PM, Paul Walmsley wrote: > On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: > >> Paul, what do you think is the best way forward to perform reset? > > Many of the IP blocks with PRM hardreset lines are processor IP blocks. > Those often need special reset handling

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-07 Thread Paul Walmsley
On Tue, 2 Feb 2016, Kishon Vijay Abraham I wrote: > Paul, what do you think is the best way forward to perform reset? Many of the IP blocks with PRM hardreset lines are processor IP blocks. Those often need special reset handling to ensure that WFI/HLT-like instructions are executed after reset

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-04 Thread Kishon Vijay Abraham I
Hi Paul, On Tuesday 02 February 2016 04:10 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 29 January 2016 12:01 AM, Tony Lindgren wrote: >> * Suman Anna [160127 15:17]: >>> On 01/27/2016 12:56 PM, Tony Lindgren wrote: * Suman Anna [160127 10:17]: > On 01/27/2016 11:31 AM, Tony L

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-02-02 Thread Kishon Vijay Abraham I
Hi, On Friday 29 January 2016 12:01 AM, Tony Lindgren wrote: > * Suman Anna [160127 15:17]: >> On 01/27/2016 12:56 PM, Tony Lindgren wrote: >>> * Suman Anna [160127 10:17]: On 01/27/2016 11:31 AM, Tony Lindgren wrote: > Why do you need another reset here? Can't you just implement PM run

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-28 Thread Suman Anna
On 01/28/2016 12:31 PM, Tony Lindgren wrote: > * Suman Anna [160127 15:17]: >> On 01/27/2016 12:56 PM, Tony Lindgren wrote: >>> * Suman Anna [160127 10:17]: On 01/27/2016 11:31 AM, Tony Lindgren wrote: > Why do you need another reset here? Can't you just implement PM runtime > in the

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-28 Thread Tony Lindgren
* Suman Anna [160127 15:17]: > On 01/27/2016 12:56 PM, Tony Lindgren wrote: > > * Suman Anna [160127 10:17]: > >> On 01/27/2016 11:31 AM, Tony Lindgren wrote: > >>> Why do you need another reset here? Can't you just implement PM runtime > >>> in the driver and do the usual pm_runtime_put_sync fol

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-27 Thread Suman Anna
On 01/27/2016 12:56 PM, Tony Lindgren wrote: > * Suman Anna [160127 10:17]: >> On 01/27/2016 11:31 AM, Tony Lindgren wrote: >>> Why do you need another reset here? Can't you just implement PM runtime >>> in the driver and do the usual pm_runtime_put_sync followed by >>> pm_runtime_disable? >> >> T

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-27 Thread Tony Lindgren
* Suman Anna [160127 10:17]: > On 01/27/2016 11:31 AM, Tony Lindgren wrote: > > Why do you need another reset here? Can't you just implement PM runtime > > in the driver and do the usual pm_runtime_put_sync followed by > > pm_runtime_disable? > > The omap_hwmod_enable/disable code does not deal w

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-27 Thread Suman Anna
Hi Tony, On 01/27/2016 11:31 AM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [160114 06:12]: >> Use assert/deassert callbacks populated in the platform data to >> to perform reset of PCIe. >> >> Use these callbacks until a reset controller driver is >> is available in the kernel to reset PCIe

Re: [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset

2016-01-27 Thread Tony Lindgren
* Kishon Vijay Abraham I [160114 06:12]: > Use assert/deassert callbacks populated in the platform data to > to perform reset of PCIe. > > Use these callbacks until a reset controller driver is > is available in the kernel to reset PCIe. ... > --- a/drivers/pci/host/pci-dra7xx.c > +++ b/drivers/