Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-25 Thread Richard Cochran
On Mon, Aug 24, 2015 at 08:16:51PM +, Hall, Christopher S wrote: > > This means: remove code changes from the PTP_SYS_OFFSET ioctl and call > getsynctime64() from a new ioctl PTP_SYS_OFFSET_PRECISE. Right? Yes. > And use the same type (struct ptp_sys_offset) for the new ioctl? Or should

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-25 Thread Richard Cochran
On Mon, Aug 24, 2015 at 08:16:51PM +, Hall, Christopher S wrote: This means: remove code changes from the PTP_SYS_OFFSET ioctl and call getsynctime64() from a new ioctl PTP_SYS_OFFSET_PRECISE. Right? Yes. And use the same type (struct ptp_sys_offset) for the new ioctl? Or should a

RE: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-24 Thread Hall, Christopher S
.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; intel-wired- > l...@lists.osuosl.org; pet...@infradead.org > Subject: Re: [PATCH v3 3/4] Add support for driver cross-timestamp to > PTP_SYS_OFFSET ioctl > > On Sun, Aug 23, 2015 at 10:15:00AM +0200, Thomas Gleixner wrote: >

RE: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-24 Thread Hall, Christopher S
; net...@vger.kernel.org; intel-wired- l...@lists.osuosl.org; pet...@infradead.org Subject: Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl On Sun, Aug 23, 2015 at 10:15:00AM +0200, Thomas Gleixner wrote: So why can't you take N samples from the synced

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-23 Thread Richard Cochran
On Sun, Aug 23, 2015 at 10:15:00AM +0200, Thomas Gleixner wrote: > So why can't you take N samples from the synced hardware? It does not > make any sense to me to switch to the imprecise mode if nsamples > 1. Ok, then I prefer to leave this "imprecise" method in place and ... > You can also

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-23 Thread Thomas Gleixner
On Sat, 22 Aug 2015, Richard Cochran wrote: > On Sat, Aug 22, 2015 at 10:33:48PM +0200, Thomas Gleixner wrote: > > > @@ -196,19 +197,31 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int > > > cmd, unsigned long arg) > > > break; > > > } > > > pct =

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-23 Thread Richard Cochran
On Sun, Aug 23, 2015 at 10:15:00AM +0200, Thomas Gleixner wrote: So why can't you take N samples from the synced hardware? It does not make any sense to me to switch to the imprecise mode if nsamples 1. Ok, then I prefer to leave this imprecise method in place and ... You can also provide a

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-23 Thread Thomas Gleixner
On Sat, 22 Aug 2015, Richard Cochran wrote: On Sat, Aug 22, 2015 at 10:33:48PM +0200, Thomas Gleixner wrote: @@ -196,19 +197,31 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) break; } pct = sysoff-ts[0]; -

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-22 Thread Richard Cochran
On Sat, Aug 22, 2015 at 10:33:48PM +0200, Thomas Gleixner wrote: > > @@ -196,19 +197,31 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int > > cmd, unsigned long arg) > > break; > > } > > pct = >ts[0]; > > - for (i = 0; i <

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-22 Thread Thomas Gleixner
On Fri, 21 Aug 2015, Christopher S. Hall wrote: > From: Christopher Hall > > This patch allows system and device time ("cross-timestamp") to be > performed by the driver. Currently, the cross-timestamping is performed > in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() >

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-22 Thread Richard Cochran
On Sat, Aug 22, 2015 at 10:33:48PM +0200, Thomas Gleixner wrote: @@ -196,19 +197,31 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) break; } pct = sysoff-ts[0]; - for (i = 0; i sysoff-n_samples; i++)

Re: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-22 Thread Thomas Gleixner
On Fri, 21 Aug 2015, Christopher S. Hall wrote: From: Christopher Hall christopher.s.h...@intel.com This patch allows system and device time (cross-timestamp) to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver

[PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-21 Thread Christopher S. Hall
From: Christopher Hall This patch allows system and device time ("cross-timestamp") to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback provided by the driver. The

[PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-21 Thread Christopher S. Hall
From: Christopher Hall christopher.s.h...@intel.com This patch allows system and device time (cross-timestamp) to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback