Re: [PATCH v3 3/4] base/platform: Continue on insert_resource() error

2015-04-23 Thread Thierry Reding
On Thu, Apr 23, 2015 at 08:26:37AM -0500, Bjorn Helgaas wrote: > On Thu, Apr 23, 2015 at 09:55:13AM +0200, Ricardo Ribalda Delgado wrote: > > Hi Bjorn: > > > > On Wed, Apr 22, 2015 at 6:44 PM, Bjorn Helgaas wrote: > > > > > Usual style for referencing a commit is "(see 02bbde7849e6 ('Revert "of:

Re: [PATCH v3 3/4] base/platform: Continue on insert_resource() error

2015-04-23 Thread Bjorn Helgaas
On Thu, Apr 23, 2015 at 09:55:13AM +0200, Ricardo Ribalda Delgado wrote: > Hi Bjorn: > > On Wed, Apr 22, 2015 at 6:44 PM, Bjorn Helgaas wrote: > > > Usual style for referencing a commit is "(see 02bbde7849e6 ('Revert "of: > > use platform_device_add"'))". > > Do you make that reference manually

Re: [PATCH v3 3/4] base/platform: Continue on insert_resource() error

2015-04-23 Thread Ricardo Ribalda Delgado
Hi Bjorn: On Wed, Apr 22, 2015 at 6:44 PM, Bjorn Helgaas wrote: > Usual style for referencing a commit is "(see 02bbde7849e6 ('Revert "of: > use platform_device_add"'))". Do you make that reference manually or there is a magic git command for printing it in that style? > > Sounds like we shou

Re: [PATCH v3 3/4] base/platform: Continue on insert_resource() error

2015-04-22 Thread Bjorn Helgaas
On Wed, Apr 22, 2015 at 06:14:20PM +0200, Ricardo Ribalda Delgado wrote: > insert_resource() can fail when the resource added overlaps > (partially or fully) with another. > > Device tree and AMBA devices may contain resources that overlap, so they > could not call platform_device_add (Revert "of

[PATCH v3 3/4] base/platform: Continue on insert_resource() error

2015-04-22 Thread Ricardo Ribalda Delgado
insert_resource() can fail when the resource added overlaps (partially or fully) with another. Device tree and AMBA devices may contain resources that overlap, so they could not call platform_device_add (Revert "of: use platform_device_add" 02bbde7849e68e193cefaa1885fe0df0f03c9fcd ) On the other