Re: [PATCH v3 3/4] bpf: Fix ORC unwinding in non-JIT BPF code

2019-06-26 Thread Josh Poimboeuf
On Wed, Jun 26, 2019 at 06:22:48PM -0700, Alexei Starovoitov wrote: > On Wed, Jun 26, 2019 at 6:07 PM Josh Poimboeuf wrote: > > > > On Wed, Jun 26, 2019 at 05:57:08PM -0700, Alexei Starovoitov wrote: > > > On Wed, Jun 26, 2019 at 5:36 PM Josh Poimboeuf > > > wrote: > > > > > > > > Objtool

Re: [PATCH v3 3/4] bpf: Fix ORC unwinding in non-JIT BPF code

2019-06-26 Thread Alexei Starovoitov
On Wed, Jun 26, 2019 at 6:07 PM Josh Poimboeuf wrote: > > On Wed, Jun 26, 2019 at 05:57:08PM -0700, Alexei Starovoitov wrote: > > On Wed, Jun 26, 2019 at 5:36 PM Josh Poimboeuf wrote: > > > > > > Objtool previously ignored ___bpf_prog_run() because it didn't > > > understand the jump table.

Re: [PATCH v3 3/4] bpf: Fix ORC unwinding in non-JIT BPF code

2019-06-26 Thread Josh Poimboeuf
On Wed, Jun 26, 2019 at 05:57:08PM -0700, Alexei Starovoitov wrote: > On Wed, Jun 26, 2019 at 5:36 PM Josh Poimboeuf wrote: > > > > Objtool previously ignored ___bpf_prog_run() because it didn't > > understand the jump table. This resulted in the ORC unwinder not being > > able to unwind through

Re: [PATCH v3 3/4] bpf: Fix ORC unwinding in non-JIT BPF code

2019-06-26 Thread Alexei Starovoitov
On Wed, Jun 26, 2019 at 5:36 PM Josh Poimboeuf wrote: > > Objtool previously ignored ___bpf_prog_run() because it didn't > understand the jump table. This resulted in the ORC unwinder not being > able to unwind through non-JIT BPF code. > > Now that objtool knows how to read jump tables, remove

[PATCH v3 3/4] bpf: Fix ORC unwinding in non-JIT BPF code

2019-06-26 Thread Josh Poimboeuf
Objtool previously ignored ___bpf_prog_run() because it didn't understand the jump table. This resulted in the ORC unwinder not being able to unwind through non-JIT BPF code. Now that objtool knows how to read jump tables, remove the whitelist and rename the variable to "jump_table" so objtool