Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-09-16 Thread Jean Delvare
Hi Wei, Sorry for the late reply, catching up with the discussions from before my vacation... On Tue, 30 Jul 2013 16:18:35 +0800, Wei Ni wrote: > On 07/29/2013 11:58 PM, Jean Delvare wrote: > > On Mon, 29 Jul 2013 18:14:56 +0800, Wei Ni wrote: > >> Yes, we had met this problems, to fix this issue

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-30 Thread Wei Ni
On 07/29/2013 11:58 PM, Jean Delvare wrote: > Hi Wei, > > On Mon, 29 Jul 2013 18:14:56 +0800, Wei Ni wrote: >> On 07/27/2013 11:02 PM, Jean Delvare wrote: >>> On Fri, 19 Jul 2013 14:41:54 +0800, Wei Ni wrote: 2. The pin ALERT/THERM2 is configured as ALERT, and it is connected to the inte

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-29 Thread Jean Delvare
Hi Wei, On Mon, 29 Jul 2013 18:14:56 +0800, Wei Ni wrote: > On 07/27/2013 11:02 PM, Jean Delvare wrote: > > On Fri, 19 Jul 2013 14:41:54 +0800, Wei Ni wrote: > >> 2. The pin ALERT/THERM2 is configured as ALERT, and it is connected to > >> the interrupt line. > > > > Why don't you use the SMBus al

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-29 Thread Wei Ni
On 07/27/2013 11:02 PM, Jean Delvare wrote: > Hi Wei, > > Sorry for the late reply. > > On Fri, 19 Jul 2013 14:41:54 +0800, Wei Ni wrote: >> On 07/18/2013 11:58 PM, Jean Delvare wrote: >>> First of all, how is the chip wired on your system? You are using an >>> NCT1008, right? Which output of the

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-27 Thread Jean Delvare
Hi Wei, Sorry for the late reply. On Fri, 19 Jul 2013 14:41:54 +0800, Wei Ni wrote: > On 07/18/2013 11:58 PM, Jean Delvare wrote: > > First of all, how is the chip wired on your system? You are using an > > NCT1008, right? Which output of the chip is connected to your interrupt > > line, THERM or

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-24 Thread Jean Delvare
Hi Wei, On Wed, 24 Jul 2013 15:46:46 +0800, Wei Ni wrote: > Do you have any more suggestions for this series, if no, I will prepare > v4 patches. Sorry, I have a couple more replies "in progress" but had friends at home last week end so I did not have the time to finish and send them. I'll try to

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-24 Thread Wei Ni
Hi, Jean On 07/19/2013 02:41 PM, Wei Ni wrote: > On 07/18/2013 11:58 PM, Jean Delvare wrote: >> Hi Wei, >> >> On Fri, 12 Jul 2013 15:48:06 +0800, Wei Ni wrote: >>> When the temperature exceed the limit range value, >>> the driver can handle the interrupt. >>> >>> Signed-off-by: Wei Ni >>> --- >>>

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-18 Thread Wei Ni
On 07/18/2013 11:58 PM, Jean Delvare wrote: > Hi Wei, > > On Fri, 12 Jul 2013 15:48:06 +0800, Wei Ni wrote: >> When the temperature exceed the limit range value, >> the driver can handle the interrupt. >> >> Signed-off-by: Wei Ni >> --- >> drivers/hwmon/lm90.c | 24 >>

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-18 Thread Jean Delvare
Hi Wei, On Fri, 12 Jul 2013 15:48:06 +0800, Wei Ni wrote: > When the temperature exceed the limit range value, > the driver can handle the interrupt. > > Signed-off-by: Wei Ni > --- > drivers/hwmon/lm90.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/driv

[PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-12 Thread Wei Ni
When the temperature exceed the limit range value, the driver can handle the interrupt. Signed-off-by: Wei Ni --- drivers/hwmon/lm90.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index c90037f..1cc3d19 100644 --- a/d