Re: [PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 02:52:57PM -0700, Ian Rogers escreveu: > On Mon, Sep 14, 2020 at 2:51 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Mon, Sep 14, 2020 at 06:46:55PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Sep 11, 2020 at 07:56:54PM -0700, Ian Rogers escreveu: > > > > If

Re: [PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-14 Thread Ian Rogers
On Mon, Sep 14, 2020 at 2:51 PM Arnaldo Carvalho de Melo wrote: > > Em Mon, Sep 14, 2020 at 06:46:55PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Sep 11, 2020 at 07:56:54PM -0700, Ian Rogers escreveu: > > > If events in a group explicitly set a frequency or period with leader > > >

Re: [PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 14, 2020 at 06:46:55PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Sep 11, 2020 at 07:56:54PM -0700, Ian Rogers escreveu: > > If events in a group explicitly set a frequency or period with leader > > sampling, don't disable the samples on those events. > > > > Prior to 5.8: >

Re: [PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-14 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 11, 2020 at 07:56:54PM -0700, Ian Rogers escreveu: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear

Re: [PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-14 Thread Adrian Hunter
On 12/09/20 5:56 am, Ian Rogers wrote: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear the attributes then

[PATCH v3 3/4] perf record: Don't clear event's period if set by a term

2020-09-11 Thread Ian Rogers
If events in a group explicitly set a frequency or period with leader sampling, don't disable the samples on those events. Prior to 5.8: perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' would clear the attributes then apply the config terms. In commit 5f34278867b7 leader