Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Michal Suchánek
On Wed, 28 Aug 2019 23:46:24 -0700 Christoph Hellwig wrote: > On Wed, Aug 28, 2019 at 06:43:50PM +0200, Michal Suchanek wrote: > > +ifdef CONFIG_COMPAT > > +obj-y += sys_ppc32.o ptrace32.o signal_32.o > > +endif > > This should be: > > obj-$(CONFIG_COMPAT)

Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Arnd Bergmann
On Thu, Aug 29, 2019 at 10:38 AM Christophe Leroy wrote: > Le 29/08/2019 à 10:01, Arnd Bergmann a écrit : > > On Thu, Aug 29, 2019 at 8:46 AM Christoph Hellwig > > wrote: > > > >>> @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk) > >>> > >>>rseq_signal_deliver(&ksig, ts

Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Christophe Leroy
Le 29/08/2019 à 10:01, Arnd Bergmann a écrit : On Thu, Aug 29, 2019 at 8:46 AM Christoph Hellwig wrote: @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk) rseq_signal_deliver(&ksig, tsk->thread.regs); - if (is32) { + if ((IS_ENABLED(CONFIG_PPC32) || IS_ENABL

Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Arnd Bergmann
On Thu, Aug 29, 2019 at 8:46 AM Christoph Hellwig wrote: > > @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk) > > > > rseq_signal_deliver(&ksig, tsk->thread.regs); > > > > - if (is32) { > > + if ((IS_ENABLED(CONFIG_PPC32) || IS_ENABLED(CONFIG_COMPAT)) && is32) { >

Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-28 Thread Christoph Hellwig
On Wed, Aug 28, 2019 at 06:43:50PM +0200, Michal Suchanek wrote: > +ifdef CONFIG_COMPAT > +obj-y+= sys_ppc32.o ptrace32.o signal_32.o > +endif This should be: obj-$(CONFIG_COMPAT)+= sys_ppc32.o ptrace32.o signal_32.o > /* This value is used to mark ex

[PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-28 Thread Michal Suchanek
There are numerous references to 32bit functions in generic and 64bit code so ifdef them out. Signed-off-by: Michal Suchanek --- v2: - fix 32bit ifdef condition in signal.c - simplify the compat ifdef condition in vdso.c - 64bit is redundant - simplify the compat ifdef condition in callchain.c -