Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node

2020-07-09 Thread Laxman Dewangan
On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote: External email: Use caution opening links or attachments The gpiochip_add_data() takes care of setting the of_node to the parent's device of_node, hence there is no need to do it manually in the driver's code. This patch corrects the

Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node

2020-07-09 Thread Dmitry Osipenko
09.07.2020 12:07, Andy Shevchenko пишет: > On Thu, Jul 9, 2020 at 12:44 AM Dmitry Osipenko wrote: >> 08.07.2020 23:57, Andy Shevchenko пишет: >>> On Wednesday, July 8, 2020, Dmitry Osipenko >> > wrote: > > ... > >>> I gave a second look and I think my suggestion is

Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node

2020-07-09 Thread Andy Shevchenko
On Thu, Jul 9, 2020 at 12:44 AM Dmitry Osipenko wrote: > 08.07.2020 23:57, Andy Shevchenko пишет: > > On Wednesday, July 8, 2020, Dmitry Osipenko > > wrote: ... > > I gave a second look and I think my suggestion is wrong. Here is an > > interesting propagation of the

Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node

2020-07-08 Thread Dmitry Osipenko
08.07.2020 23:57, Andy Shevchenko пишет: > > > On Wednesday, July 8, 2020, Dmitry Osipenko > wrote: > > The gpiochip_add_data() takes care of setting the of_node to the > parent's > device of_node, hence there is no need to do it manually in the driver's >

[PATCH v3 3/6] gpio: max77620: Don't set of_node

2020-07-08 Thread Dmitry Osipenko
The gpiochip_add_data() takes care of setting the of_node to the parent's device of_node, hence there is no need to do it manually in the driver's code. This patch corrects the parent's device pointer and removes the unnecessary setting of the of_node. Suggested-by: Andy Shevchenko