Re: [PATCH v3 3/6] spi: spi-mtk-nor: support 7 bytes transfer of generic spi

On Fri, Sep 25, 2020 at 3:47 PM Chuanhong Guo wrote: > > Hi! > > On Fri, Sep 25, 2020 at 2:55 PM Ikjoon Jang wrote: > > > > When mtk-nor fallbacks to generic spi transfers, it can actually > > transfer up to 7 bytes. > > generic transfer_one_message should support full-duplex transfers, > not tra

Re: [PATCH v3 3/6] spi: spi-mtk-nor: support 7 bytes transfer of generic spi

HI! One more comment: On Fri, Sep 25, 2020 at 2:55 PM Ikjoon Jang wrote: > +static bool mtk_nor_check_prg(const struct spi_mem_op *op) > +{ > + size_t len = op->cmd.nbytes + op->addr.nbytes + op->dummy.nbytes; > + > + if (len > MTK_NOR_PRG_MAX_SIZE) > + return false; > +

Re: [PATCH v3 3/6] spi: spi-mtk-nor: support 7 bytes transfer of generic spi

Hi! On Fri, Sep 25, 2020 at 2:55 PM Ikjoon Jang wrote: > > When mtk-nor fallbacks to generic spi transfers, it can actually > transfer up to 7 bytes. generic transfer_one_message should support full-duplex transfers, not transfers with special format requirements. (e.g. here the last byte is rx

[PATCH v3 3/6] spi: spi-mtk-nor: support 7 bytes transfer of generic spi

When mtk-nor fallbacks to generic spi transfers, it can actually transfer up to 7 bytes. This patch fixes adjust_op_size() and supports_op() to explicitly check 7 bytes range and also fixes possible under/overflow conditions in register offsets calculation. Signed-off-by: Ikjoon Jang --- (no ch