Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-20 Thread Clément Péron
Hi Maxime, On Thu, 17 Sep 2020 at 16:06, Maxime Ripard wrote: > > Hi Clement, > > On Thu, Sep 17, 2020 at 03:55:45PM +0200, Clément Péron wrote: > > Hi Maxime and Samuel, > > > > On Thu, 17 Sep 2020 at 15:21, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Sat, Sep 12, 2020 at 03:29:55PM

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-17 Thread Maxime Ripard
Hi Clement, On Thu, Sep 17, 2020 at 03:55:45PM +0200, Clément Péron wrote: > Hi Maxime and Samuel, > > On Thu, 17 Sep 2020 at 15:21, Maxime Ripard wrote: > > > > Hi, > > > > On Sat, Sep 12, 2020 at 03:29:55PM -0500, Samuel Holland wrote: > > > On 9/10/20 9:33 AM, Maxime Ripard wrote: > > > > On

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-17 Thread Clément Péron
Hi Maxime and Samuel, On Thu, 17 Sep 2020 at 15:21, Maxime Ripard wrote: > > Hi, > > On Sat, Sep 12, 2020 at 03:29:55PM -0500, Samuel Holland wrote: > > On 9/10/20 9:33 AM, Maxime Ripard wrote: > > > On Thu, Sep 03, 2020 at 09:54:39PM -0500, Samuel Holland wrote: > > >> On 9/3/20 3:58 PM, Maxime

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-17 Thread Maxime Ripard
Hi, On Sat, Sep 12, 2020 at 03:29:55PM -0500, Samuel Holland wrote: > On 9/10/20 9:33 AM, Maxime Ripard wrote: > > On Thu, Sep 03, 2020 at 09:54:39PM -0500, Samuel Holland wrote: > >> On 9/3/20 3:58 PM, Maxime Ripard wrote: > >>> On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote: >

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-12 Thread Samuel Holland
Maxime, On 9/10/20 9:33 AM, Maxime Ripard wrote: > On Thu, Sep 03, 2020 at 09:54:39PM -0500, Samuel Holland wrote: >> On 9/3/20 3:58 PM, Maxime Ripard wrote: >>> On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote: Hi Maxime, On Wed, 29 Jul 2020 at 17:16, Mark Brown

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-03 Thread Samuel Holland
Maxime, On 9/3/20 3:58 PM, Maxime Ripard wrote: > On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote: >> Hi Maxime, >> >> On Wed, 29 Jul 2020 at 17:16, Mark Brown wrote: >>> >>> On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote: >>> It really looks like the polarity

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-03 Thread Maxime Ripard
On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote: > Hi Maxime, > > On Wed, 29 Jul 2020 at 17:16, Mark Brown wrote: > > > > On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote: > > > > > It really looks like the polarity of LRCK is fine though. The first word > > > is sent

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-03 Thread Clément Péron
Hi Maxime, On Wed, 29 Jul 2020 at 17:16, Mark Brown wrote: > > On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote: > > > It really looks like the polarity of LRCK is fine though. The first word > > is sent with LRCK low, and then high, so we have channel 0 and then > > channel 1 which

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-07-29 Thread Mark Brown
On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote: > It really looks like the polarity of LRCK is fine though. The first word > is sent with LRCK low, and then high, so we have channel 0 and then > channel 1 which seems to be the proper ordering? Yes, that's normal. signature.asc

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-05-04 Thread Clément Péron
Hi Maxime, On Mon, 4 May 2020 at 14:09, Maxime Ripard wrote: > > Hi Clement, > > On Thu, Apr 30, 2020 at 04:00:14PM +0200, Clément Péron wrote: > > On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Clément Péron wrote: > > > > On Wed, 29 Apr 2020

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-05-04 Thread Maxime Ripard
Hi Clement, On Thu, Apr 30, 2020 at 04:00:14PM +0200, Clément Péron wrote: > On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Clément Péron wrote: > > > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > > > > > On Tue, Apr 28, 2020 at

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-30 Thread Clément Péron
Hi Maxime, On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > Hi, > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Clément Péron wrote: > > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Clément Péron wrote: > > > > > > +static int

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-30 Thread Maxime Ripard
Hi, On Wed, Apr 29, 2020 at 06:33:00PM +0200, Clément Péron wrote: > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Clément Péron wrote: > > > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s, > > > > > +

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-29 Thread Clément Péron
Hi Maxime, On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Clément Péron wrote: > > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s, > > > > + unsigned int fmt) > > > > > > The alignment is off here

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-29 Thread Maxime Ripard
On Tue, Apr 28, 2020 at 10:55:47AM +0200, Clément Péron wrote: > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s, > > > + unsigned int fmt) > > > > The alignment is off here > > > > > +{ > > > + u32 mode, val; > > > + u8 offset; > > > + > > >

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-28 Thread Clément Péron
Hi Maxime, On Tue, 28 Apr 2020 at 10:13, Maxime Ripard wrote: > > Hi, > > On Sun, Apr 26, 2020 at 12:41:11PM +0200, Clément Péron wrote: > > From: Jernej Skrabec > > > > H6 I2S is very similar to that in H3, except it supports up to 16 > > channels. > > > > Signed-off-by: Jernej Skrabec > >

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-04-28 Thread Maxime Ripard
Hi, On Sun, Apr 26, 2020 at 12:41:11PM +0200, Clément Péron wrote: > From: Jernej Skrabec > > H6 I2S is very similar to that in H3, except it supports up to 16 > channels. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- >