Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2

2015-12-20 Thread Jarkko Sakkinen
On Fri, Dec 18, 2015 at 09:51:27AM -0700, Jason Gunthorpe wrote: > On Fri, Dec 18, 2015 at 11:34:32AM +0200, Jarkko Sakkinen wrote: > > > + st = acpi_get_table(ACPI_SIG_TPM2, 1, > > > + (struct acpi_table_header **) &tbl); > > > + if (ACPI_FAILURE(st) || tbl->header.length < siz

Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2

2015-12-18 Thread Jason Gunthorpe
On Fri, Dec 18, 2015 at 11:34:32AM +0200, Jarkko Sakkinen wrote: > > + st = acpi_get_table(ACPI_SIG_TPM2, 1, > > + (struct acpi_table_header **) &tbl); > > + if (ACPI_FAILURE(st) || tbl->header.length < sizeof(*tbl)) { > > + dev_err(&acpi_dev->dev, > > +

Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2

2015-12-18 Thread Jarkko Sakkinen
On Thu, Dec 17, 2015 at 11:23:16AM -0700, Jason Gunthorpe wrote: > If the ACPI tables do not declare a memory resource for the TPM2 > then do not just fall back to the x86 default base address. > > Also be stricter when checking the ancillary TPM2 ACPI data and error > out if any of this data is w

[PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2

2015-12-17 Thread Jason Gunthorpe
If the ACPI tables do not declare a memory resource for the TPM2 then do not just fall back to the x86 default base address. Also be stricter when checking the ancillary TPM2 ACPI data and error out if any of this data is wrong rather than blindly assuming TPM1. Fixes: 399235dc6e95 ("tpm, tpm_tis