Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Rohit Kumar
On 7/9/2020 3:36 PM, Srinivas Kandagatla wrote: On 09/07/2020 10:57, Rohit Kumar wrote: Thanks Srini for reviewing. On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants o

Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Srinivas Kandagatla
On 09/07/2020 10:57, Rohit Kumar wrote: Thanks Srini for reviewing. On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg

Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Rohit Kumar
Thanks Srini for reviewing. On 7/9/2020 2:56 PM, Srinivas Kandagatla wrote: On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and remove

Re: [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-09 Thread Srinivas Kandagatla
On 08/07/2020 06:08, Rohit kumar wrote: I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by:

[PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers

2020-07-07 Thread Rohit kumar
I2SCTL and DMACTL registers has different bits alignment for newer LPASS variants of SC7180 soc. Use REG_FIELD_ID() to define the reg_fields in platform specific file and removed shifts and mask macros for such registers from header file. Signed-off-by: Rohit kumar --- sound/soc/qcom/lpass-apq80