Re: [PATCH v3 3/8] KVM: X86: Introduce kvm_check_cpuid()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 14:28, Xiaoyao Li wrote: >> @@ -202,12 +208,16 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu, >>   vcpu->arch.cpuid_entries[i].padding[2] = 0; >>   } >>   vcpu->arch.cpuid_nent = cpuid->nent; >> +    r = kvm_check_cpuid(vcpu); >> +    if (r) { >> +   

Re: [PATCH v3 3/8] KVM: X86: Introduce kvm_check_cpuid()

2020-07-08 Thread Xiaoyao Li
On 7/8/2020 2:50 PM, Xiaoyao Li wrote: Use kvm_check_cpuid() to validate if userspace provides legal cpuid settings and call it before KVM updates CPUID. Signed-off-by: Xiaoyao Li [...] @@ -202,12 +208,16 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu,

[PATCH v3 3/8] KVM: X86: Introduce kvm_check_cpuid()

2020-07-08 Thread Xiaoyao Li
Use kvm_check_cpuid() to validate if userspace provides legal cpuid settings and call it before KVM updates CPUID. Signed-off-by: Xiaoyao Li --- Is the check of virutal address width really necessary? KVM doesn't check other bits at all. I guess the policy is that KVM allows illegal CPUID