Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-24 Thread Joe Lawrence
On 4/24/19 1:47 PM, Miroslav Benes wrote: On Tue, 23 Apr 2019, Joe Lawrence wrote: diff --git a/scripts/livepatch/klp-convert.c b/scripts/livepatch/klp-convert.c index 82c27d219372..126395f1c0cd 100644 --- a/scripts/livepatch/klp-convert.c +++ b/scripts/livepatch/klp-convert.c @@ -517,6 +517,7 @

Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-24 Thread Miroslav Benes
On Tue, 23 Apr 2019, Joe Lawrence wrote: > On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote: > > > > [ ... snip ... ] > > > > +static bool convert_rela(struct section *oldsec, struct rela *r, > > + struct sympos *sp, struct elf *klp_elf) > > +{ > > + struct section *sec;

Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-23 Thread Joe Lawrence
On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote: > > [ ... snip ... ] > > +static bool convert_rela(struct section *oldsec, struct rela *r, > + struct sympos *sp, struct elf *klp_elf) > +{ > + struct section *sec; > + struct rela *r1, *r2; > + > + sec = get_or

Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-12 Thread Miroslav Benes
On Wed, 10 Apr 2019, Joe Lawrence wrote: > On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote: > > > > [ ... snip ... ] > > > > diff --git a/scripts/livepatch/klp-convert.c > > b/scripts/livepatch/klp-convert.c > > new file mode 100644 > > index ..62bd26941081 > > --- /dev/n

Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-10 Thread Joe Lawrence
On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote: > > [ ... snip ... ] > > diff --git a/scripts/livepatch/klp-convert.c b/scripts/livepatch/klp-convert.c > new file mode 100644 > index ..62bd26941081 > --- /dev/null > +++ b/scripts/livepatch/klp-convert.c > > [ ... snip ...

[PATCH v3 3/9] livepatch: Add klp-convert tool

2019-04-10 Thread Joe Lawrence
From: Josh Poimboeuf Livepatches may use symbols which are not contained in its own scope, and, because of that, may end up compiled with relocations that will only be resolved during module load. Yet, when the referenced symbols are not exported, solving this relocation requires information on t