Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-20 Thread Jyri Sarha
On 03/19/2014 09:31 PM, Lars-Peter Clausen wrote: On 03/19/2014 08:21 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 09:15:14PM +0200, Jyri Sarha wrote: On 03/19/2014 08:51 PM, Lars-Peter Clausen wrote: When does this make sense? Either the bitclock is inverted for all of them or for none.

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Jyri Sarha
On 03/19/2014 08:51 PM, Lars-Peter Clausen wrote: On 03/19/2014 11:08 AM, Jyri Sarha wrote: [...] It may sometimes be helpful to allow overwriting link level settings in dai level. In order to do that it should be possible to write all daifmt settings explicitly like this: bitclock-inversion =

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Mark Brown
On Wed, Mar 19, 2014 at 08:32:06PM +0200, Jyri Sarha wrote: > On 03/19/2014 03:46 PM, Mark Brown wrote: > >It seems it'd be a bit more idiomatic to do that with a phandle rather > >than with a string in order to allow extensions for things like TDM (the > >I2S to mono speaker driver use case for e

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Lars-Peter Clausen
On 03/19/2014 08:21 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 09:15:14PM +0200, Jyri Sarha wrote: On 03/19/2014 08:51 PM, Lars-Peter Clausen wrote: When does this make sense? Either the bitclock is inverted for all of them or for none. Definition of clock signal and it's inversion vari

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Mark Brown
On Wed, Mar 19, 2014 at 09:15:14PM +0200, Jyri Sarha wrote: > On 03/19/2014 08:51 PM, Lars-Peter Clausen wrote: > >When does this make sense? Either the bitclock is inverted for all of > >them or for none. > Definition of clock signal and it's inversion varies between chip > manufacturers and som

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Lars-Peter Clausen
On 03/19/2014 11:08 AM, Jyri Sarha wrote: [...] It may sometimes be helpful to allow overwriting link level settings in dai level. In order to do that it should be possible to write all daifmt settings explicitly like this: bitclock-inversion = <0>; /* <0> = no bitclock-inversion */ When does

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Jyri Sarha
On 03/19/2014 03:46 PM, Mark Brown wrote: On Wed, Mar 19, 2014 at 12:08:55PM +0200, Jyri Sarha wrote: While we are at it we could update the bitclock-master and frame-master syntax to be like this: bitclock-master = "cpu" frame-master = "codec" With the above explicit definition all the d

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Jean-Francois Moine
On Wed, 19 Mar 2014 12:08:55 +0200 Jyri Sarha wrote: > sound { > compatible = "simple-audio-card"; > simple-audio-card,name = "Simple Audio"; > simple-audio-card,widgets = ... > simple-audio-card,routing = ... > > simple-audio-card,dai-link@0 { /* I2S - cod

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Mark Brown
On Wed, Mar 19, 2014 at 12:08:55PM +0200, Jyri Sarha wrote: > While we are at it we could update the bitclock-master and frame-master > syntax to be like this: > bitclock-master = "cpu" > frame-master = "codec" > With the above explicit definition all the daifmt settings could be defined > in li

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Jyri Sarha
On 03/18/2014 10:17 AM, Jean-Francois Moine wrote: On Mon, 17 Mar 2014 16:43:39 + Mark Brown wrote: On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: [snip] ... I agree. I see two possible syntaxes: 1) keep the same definitions in the containers: sound {

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 09:17:28AM +0100, Jean-Francois Moine wrote: > The 2nd syntax is simpler and clearer, but the properties of the CPU > DAI and of the CODEC DAI are the same in the container (format, clock > and PCM slots). Is this a problem? Yes, things like clocks might be different. We

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-18 Thread Jean-Francois Moine
On Mon, 17 Mar 2014 16:43:39 + Mark Brown wrote: > On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: [snip] > > +sound { > > + compatible = "simple-audio-card"; > > + simple-audio-card,name = "Cubox Audio"; > > + > > + simple-audio-card,cpu@0 { /

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-17 Thread Mark Brown
On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: > There may be many couples of CPU/CODEC DAI links. > The example 2 is extracted from the Cubox DT. Oh, here's some documentation - please include the documentation before the code, without the documentation the reader is going t

Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-17 Thread Jyri Sarha
On 2014-03-15 13:30, Jean-Francois Moine wrote: There may be many couples of CPU/CODEC DAI links. The example 2 is extracted from the Cubox DT. Signed-off-by: Jean-Francois Moine --- [...] This binding forces all the dai links to share the same card level properties. I find it problematic in

[PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-15 Thread Jean-Francois Moine
There may be many couples of CPU/CODEC DAI links. The example 2 is extracted from the Cubox DT. Signed-off-by: Jean-Francois Moine --- .../devicetree/bindings/sound/simple-card.txt | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/devic