Re: [PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

2016-11-09 Thread Radim Krčmář
2016-11-09 13:12+0100, Radim Krčmář: > 2016-11-09 00:25+0100, Paolo Bonzini: >> On 08/11/2016 20:54, Radim Krčmář wrote: >>> +static int em_fxsave(struct x86_emulate_ctxt *ctxt) >>> +{ >>> + struct fxregs_state fx_state; >>> + size_t size = 288; /* up to XMM7 */ >> >> Sorry for noticing this o

Re: [PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

2016-11-09 Thread Radim Krčmář
2016-11-09 00:25+0100, Paolo Bonzini: > On 08/11/2016 20:54, Radim Krčmář wrote: >> Internal errors were reported on 16 bit fxsave and fxrstor with ipxe. >> Old Intels don't have unrestricted_guest, so we have to emulate them. >> >> The patch takes advantage of the hardware implementation. >> >>

Re: [PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

2016-11-08 Thread Paolo Bonzini
On 08/11/2016 20:54, Radim Krčmář wrote: > Internal errors were reported on 16 bit fxsave and fxrstor with ipxe. > Old Intels don't have unrestricted_guest, so we have to emulate them. > > The patch takes advantage of the hardware implementation. > > Signed-off-by: Radim Krčmář > --- > v3: >

[PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR

2016-11-08 Thread Radim Krčmář
Internal errors were reported on 16 bit fxsave and fxrstor with ipxe. Old Intels don't have unrestricted_guest, so we have to emulate them. The patch takes advantage of the hardware implementation. Signed-off-by: Radim Krčmář --- v3: - remove fxsave64 and extra colons at the end of asm to make