Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-12 Thread Marc Kleine-Budde
On 01/12/2015 01:26 PM, Ahmed S. Darwish wrote: > On Mon, Jan 12, 2015 at 12:51:49PM +0100, Marc Kleine-Budde wrote: >> On 01/08/2015 04:19 PM, Ahmed S. Darwish wrote: >> >> [...] >> > MODULE_DEVICE_TABLE(usb, kvaser_usb_table); > @@ -463,7 +631,18 @@ static int kvaser_usb_get_software_inf

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-12 Thread Ahmed S. Darwish
On Mon, Jan 12, 2015 at 12:51:49PM +0100, Marc Kleine-Budde wrote: > On 01/08/2015 04:19 PM, Ahmed S. Darwish wrote: > > [...] > > >>> MODULE_DEVICE_TABLE(usb, kvaser_usb_table); > >>> @@ -463,7 +631,18 @@ static int kvaser_usb_get_software_info(struct > >>> kvaser_usb *dev) > >>> if (err) >

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-12 Thread Marc Kleine-Budde
On 01/08/2015 04:19 PM, Ahmed S. Darwish wrote: [...] >>> MODULE_DEVICE_TABLE(usb, kvaser_usb_table); >>> @@ -463,7 +631,18 @@ static int kvaser_usb_get_software_info(struct >>> kvaser_usb *dev) >>> if (err) >>> return err; >>> >>> - dev->fw_version = le32_to_cpu(msg.u.softi

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-09 Thread Marc Kleine-Budde
On 01/09/2015 04:06 AM, Ahmed S. Darwish wrote: >>> >>> cf->can_id |= CAN_ERR_CRTL; >>> cf->data[1] = CAN_ERR_CRTL_RX_OVERFLOW; >>> >>> stats->rx_over_errors++; >>> stats->rx_errors++; >>> >>> netif_rx(skb); >>> >>> stats->rx_p

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-08 Thread Ahmed S. Darwish
On Thu, Jan 08, 2015 at 12:53:37PM +0100, Marc Kleine-Budde wrote: > On 01/05/2015 07:31 PM, Ahmed S. Darwish wrote: > > [...] > > > > cf->can_id |= CAN_ERR_CRTL; > > cf->data[1] = CAN_ERR_CRTL_RX_OVERFLOW; > > > > stats->rx_over_errors++; > > st

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-08 Thread Ahmed S. Darwish
Hi Marc, On Thu, Jan 08, 2015 at 12:53:37PM +0100, Marc Kleine-Budde wrote: > On 01/05/2015 07:31 PM, Ahmed S. Darwish wrote: > > From: Ahmed S. Darwish [...] > > +/* Kvaser USB CAN dongles are divided into two major families: > > + * - Leaf: Based on Renesas M32C, running firmware labeled as 'fi

Re: [PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-08 Thread Marc Kleine-Budde
On 01/05/2015 07:31 PM, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish > > CAN to USB interfaces sold by the Swedish manufacturer Kvaser are > divided into two major families: 'Leaf', and 'UsbcanII'. From an > Operating System perspective, the firmware of both families behave > in a not too dr

[PATCH v3 4/4] can: kvaser_usb: Add support for the Usbcan-II family

2015-01-05 Thread Ahmed S. Darwish
From: Ahmed S. Darwish CAN to USB interfaces sold by the Swedish manufacturer Kvaser are divided into two major families: 'Leaf', and 'UsbcanII'. From an Operating System perspective, the firmware of both families behave in a not too drastically different fashion. This patch adds support for th