Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-03-23 Thread Laurent Pinchart
Hi Paul, Thank you for the patch. On Sun, Jan 24, 2021 at 08:55:52AM +, Paul Cercueil wrote: > Even though the JZ4740 did not have the OSD mode, it had (according to > the documentation) two DMA channels, but there is absolutely no > information about how to select the second DMA channel. >

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-25 Thread H. Nikolaus Schaller
Hi Paul, > Am 24.01.2021 um 10:47 schrieb H. Nikolaus Schaller : > > Hi Paul, > >> Am 24.01.2021 um 10:43 schrieb Paul Cercueil : >> >> Hi Nikolaus, >> >> Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a >> écrit : >>> Hi Paul, >>> we observed the same issue on the jz4730 (which is almo

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread H. Nikolaus Schaller
Hi Paul, > Am 24.01.2021 um 10:43 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a > écrit : >> Hi Paul, >> we observed the same issue on the jz4730 (which is almost identical >> to the jz4740 wrt. LCDC) and our solution [1] was simpler. >> It

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread Paul Cercueil
Hi Nikolaus, Le dim. 24 janv. 2021 à 10:30, H. Nikolaus Schaller a écrit : Hi Paul, we observed the same issue on the jz4730 (which is almost identical to the jz4740 wrt. LCDC) and our solution [1] was simpler. It leaves the hwdesc f0 and f1 as they are and just takes f1 for really programm

Re: [PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread H. Nikolaus Schaller
Hi Paul, we observed the same issue on the jz4730 (which is almost identical to the jz4740 wrt. LCDC) and our solution [1] was simpler. It leaves the hwdesc f0 and f1 as they are and just takes f1 for really programming the first DMA descriptor if there is no OSD. We have tested on jz4730 and jz4

[PATCH v3 4/4] drm/ingenic: Fix non-OSD mode

2021-01-24 Thread Paul Cercueil
Even though the JZ4740 did not have the OSD mode, it had (according to the documentation) two DMA channels, but there is absolutely no information about how to select the second DMA channel. Make the ingenic-drm driver work in non-OSD mode by using the foreground0 plane (which is bound to the DMA0