Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources

2020-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2020 at 07:36:55PM +0900, David Stevens wrote: > On Mon, Jun 8, 2020 at 6:43 PM Michael S. Tsirkin wrote: > > > > On Fri, May 15, 2020 at 04:26:15PM +0900, David Stevens wrote: > > > > > + if (virtio_has_feature(vgdev->vdev, > > > > > VIRTIO_GPU_F_RESOURCE_UUID)) { > > > > > +

Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources

2020-06-08 Thread David Stevens
On Mon, Jun 8, 2020 at 6:43 PM Michael S. Tsirkin wrote: > > On Fri, May 15, 2020 at 04:26:15PM +0900, David Stevens wrote: > > > > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) { > > > > + vgdev->has_resource_assign_uuid = true; > > > > + } > > > > > > > >

Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources

2020-06-08 Thread Michael S. Tsirkin
On Fri, May 15, 2020 at 04:26:15PM +0900, David Stevens wrote: > > > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) { > > > + vgdev->has_resource_assign_uuid = true; > > > + } > > > > > > Just a question: this relies on DMA bufs so I assume it is > > not real

Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources

2020-05-15 Thread David Stevens
> > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) { > > + vgdev->has_resource_assign_uuid = true; > > + } > > > Just a question: this relies on DMA bufs so I assume it is > not really assumed to work when DMA API is bypassed, right? > Rather than worry what

Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources

2020-05-13 Thread Michael S. Tsirkin
On Wed, Mar 11, 2020 at 08:20:04PM +0900, David Stevens wrote: > Add support for UUID-based resource sharing mechanism to virtgpu. This > implements the new virtgpu commands and hooks them up to dma-buf's > get_uuid callback. > > Signed-off-by: David Stevens > --- > drivers/gpu/drm/virtio/virtgp