Re: [PATCH v3 4/4] of/platform: Use platform_device interface

2015-04-23 Thread Ricardo Ribalda Delgado
Hello Rob On Thu, Apr 23, 2015 at 9:28 AM, Ricardo Ribalda Delgado wrote: > > I think it can also use platform_device_add. I will prepare a patch to > finally remove of_device_add() I will post right away an updated version of this patchset, and then I will prepare another one to remove of_devic

Re: [PATCH v3 4/4] of/platform: Use platform_device interface

2015-04-23 Thread Ricardo Ribalda Delgado
Hello Rob On Wed, Apr 22, 2015 at 6:25 PM, Rob Herring wrote: >> This patch, replaces of_device_add() with platform_device_data(). > > This doesn't match the change. Thanks for catching it up. Will fix it and resend >> - if (of_device_add(dev) != 0) { >> + if (platform_device_add(d

Re: [PATCH v3 4/4] of/platform: Use platform_device interface

2015-04-22 Thread Rob Herring
On Wed, Apr 22, 2015 at 11:14 AM, Ricardo Ribalda Delgado wrote: > of_platform_device_create_pdata() was using of_device_add() to create > the devices, but of_platform_device_destroy was using > of_platform_device_destroy(). > > of_device_add(), do not call insert_resource(), which initializes the

[PATCH v3 4/4] of/platform: Use platform_device interface

2015-04-22 Thread Ricardo Ribalda Delgado
of_platform_device_create_pdata() was using of_device_add() to create the devices, but of_platform_device_destroy was using of_platform_device_destroy(). of_device_add(), do not call insert_resource(), which initializes the parent field of the resource structure, needed by release_resource(), call