Re: [PATCH v3 4/4] x86/kvm: use __decrypted attribute in shared variables

2018-08-30 Thread Brijesh Singh
On 08/29/2018 02:56 PM, Sean Christopherson wrote: On Wed, Aug 29, 2018 at 01:24:00PM -0500, Brijesh Singh wrote: The following commit: 368a540e0232 (x86/kvmclock: Remove memblock dependency) Checkpatch prefers: Commit 368a540e0232 ("x86/kvmclock: Remove memblock dependency") Tha

Re: [PATCH v3 4/4] x86/kvm: use __decrypted attribute in shared variables

2018-08-29 Thread Sean Christopherson
On Wed, Aug 29, 2018 at 01:24:00PM -0500, Brijesh Singh wrote: > The following commit: > > 368a540e0232 (x86/kvmclock: Remove memblock dependency) Checkpatch prefers: Commit 368a540e0232 ("x86/kvmclock: Remove memblock dependency") That'll also save three lines in the commit message. >

[PATCH v3 4/4] x86/kvm: use __decrypted attribute in shared variables

2018-08-29 Thread Brijesh Singh
The following commit: 368a540e0232 (x86/kvmclock: Remove memblock dependency) caused SEV guest regression. When SEV is active, we map the shared variables (wall_clock and hv_clock_boot) with C=0 to ensure that both the guest and the hypervisor is able to access the data. To map the variables we