Re: [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

Hi, On 29/08/20 05:30, kernel test robot wrote: > Hi Luca, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on v5.9-rc2] > [also build test WARNING on next-20200828] > [cannot apply to xlnx/master] > [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

Hi Luca, I love your patch! Perhaps something to improve: [auto build test WARNING on v5.9-rc2] [also build test WARNING on next-20200828] [cannot apply to xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

[PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

Current code calls gpiod_get_value() without error checking. Should the GPIO controller fail, execution would continue without any error message. Fix by checking for negative error values. Reported-by: Tom Rix Signed-off-by: Luca Ceresoli --- Changes in v3: - rebase on previous patches