Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Dmitry Osipenko
On Monday, 11 June 2018 14:50:13 MSK Boris Brezillon wrote: > On Mon, 11 Jun 2018 14:45:45 +0300 > > Dmitry Osipenko wrote: > > On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > > > On Sun, 10 Jun 2018 18:00:06 +0300 > > > > > > Dmitry Osipenko wrote: > > > > > >> That seems a lot

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Dmitry Osipenko
On Monday, 11 June 2018 14:50:13 MSK Boris Brezillon wrote: > On Mon, 11 Jun 2018 14:45:45 +0300 > > Dmitry Osipenko wrote: > > On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > > > On Sun, 10 Jun 2018 18:00:06 +0300 > > > > > > Dmitry Osipenko wrote: > > > > > >> That seems a lot

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Boris Brezillon
On Mon, 11 Jun 2018 14:45:45 +0300 Dmitry Osipenko wrote: > On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > > On Sun, 10 Jun 2018 18:00:06 +0300 > > > > Dmitry Osipenko wrote: > > > > >> That seems a lot of work for a code path I do not intend to ever use > > > > >> :-) > > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Boris Brezillon
On Mon, 11 Jun 2018 14:45:45 +0300 Dmitry Osipenko wrote: > On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > > On Sun, 10 Jun 2018 18:00:06 +0300 > > > > Dmitry Osipenko wrote: > > > > >> That seems a lot of work for a code path I do not intend to ever use > > > > >> :-) > > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Dmitry Osipenko
On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > On Sun, 10 Jun 2018 18:00:06 +0300 > > Dmitry Osipenko wrote: > > > >> That seems a lot of work for a code path I do not intend to ever use > > > >> :-) > > > > > > > > Are you sure that resetting HW resets the timing and other

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-11 Thread Dmitry Osipenko
On Sunday, 10 June 2018 18:32:02 MSK Boris Brezillon wrote: > On Sun, 10 Jun 2018 18:00:06 +0300 > > Dmitry Osipenko wrote: > > > >> That seems a lot of work for a code path I do not intend to ever use > > > >> :-) > > > > > > > > Are you sure that resetting HW resets the timing and other

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Boris Brezillon
On Sun, 10 Jun 2018 18:00:06 +0300 Dmitry Osipenko wrote: > > >> That seems a lot of work for a code path I do not intend to ever use :-) > > >> > > > > > > Are you sure that resetting HW resets the timing and other registers > > > configuration? Reset implementation is HW-specific, like for

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Boris Brezillon
On Sun, 10 Jun 2018 18:00:06 +0300 Dmitry Osipenko wrote: > > >> That seems a lot of work for a code path I do not intend to ever use :-) > > >> > > > > > > Are you sure that resetting HW resets the timing and other registers > > > configuration? Reset implementation is HW-specific, like for

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Dmitry Osipenko
On Sunday, 10 June 2018 14:09:24 MSK Stefan Agner wrote: > On 09.06.2018 14:21, Dmitry Osipenko wrote: > > On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: > >> On 01.06.2018 11:20, Dmitry Osipenko wrote: > >> > On 01.06.2018 01:16, Stefan Agner wrote: > >> >> Add support for the NAND

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Dmitry Osipenko
On Sunday, 10 June 2018 14:09:24 MSK Stefan Agner wrote: > On 09.06.2018 14:21, Dmitry Osipenko wrote: > > On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: > >> On 01.06.2018 11:20, Dmitry Osipenko wrote: > >> > On 01.06.2018 01:16, Stefan Agner wrote: > >> >> Add support for the NAND

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Stefan Agner
On 09.06.2018 14:21, Dmitry Osipenko wrote: > On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: >> On 01.06.2018 11:20, Dmitry Osipenko wrote: >> > On 01.06.2018 01:16, Stefan Agner wrote: >> >> Add support for the NAND flash controller found on NVIDIA >> >> Tegra 2 SoCs. This

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-10 Thread Stefan Agner
On 09.06.2018 14:21, Dmitry Osipenko wrote: > On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: >> On 01.06.2018 11:20, Dmitry Osipenko wrote: >> > On 01.06.2018 01:16, Stefan Agner wrote: >> >> Add support for the NAND flash controller found on NVIDIA >> >> Tegra 2 SoCs. This

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Dmitry Osipenko
On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: > On 01.06.2018 11:20, Dmitry Osipenko wrote: > > On 01.06.2018 01:16, Stefan Agner wrote: > >> Add support for the NAND flash controller found on NVIDIA > >> Tegra 2 SoCs. This implementation does not make use of the > >> command queue

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Dmitry Osipenko
On Saturday, 9 June 2018 00:51:01 MSK Stefan Agner wrote: > On 01.06.2018 11:20, Dmitry Osipenko wrote: > > On 01.06.2018 01:16, Stefan Agner wrote: > >> Add support for the NAND flash controller found on NVIDIA > >> Tegra 2 SoCs. This implementation does not make use of the > >> command queue

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner wrote: > + > +static int tegra_nand_chips_init(struct device *dev, > + struct tegra_nand_controller *ctrl) > +{ > + struct device_node *np = dev->of_node; > + struct device_node *np_nand; > + int nchips =

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner wrote: > + > +static int tegra_nand_chips_init(struct device *dev, > + struct tegra_nand_controller *ctrl) > +{ > + struct device_node *np = dev->of_node; > + struct device_node *np_nand; > + int nchips =

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 9 Jun 2018 08:46:15 +0200 Boris Brezillon wrote: > On Sat, 9 Jun 2018 08:41:57 +0200 > Boris Brezillon wrote: > > > On Sat, 09 Jun 2018 08:23:51 +0200 > > Stefan Agner wrote: > > > > > On 09.06.2018 07:52, Boris Brezillon wrote: > > > > On Fri, 08 Jun 2018 23:51:01 +0200 > > > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 9 Jun 2018 08:46:15 +0200 Boris Brezillon wrote: > On Sat, 9 Jun 2018 08:41:57 +0200 > Boris Brezillon wrote: > > > On Sat, 09 Jun 2018 08:23:51 +0200 > > Stefan Agner wrote: > > > > > On 09.06.2018 07:52, Boris Brezillon wrote: > > > > On Fri, 08 Jun 2018 23:51:01 +0200 > > > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Stefan Agner
On 09.06.2018 08:41, Boris Brezillon wrote: > On Sat, 09 Jun 2018 08:23:51 +0200 > Stefan Agner wrote: > >> On 09.06.2018 07:52, Boris Brezillon wrote: >> > On Fri, 08 Jun 2018 23:51:01 +0200 >> > Stefan Agner wrote: >> > >> > >> >> > >> >> > void tegra_nand_controller_reset(struct

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Stefan Agner
On 09.06.2018 08:41, Boris Brezillon wrote: > On Sat, 09 Jun 2018 08:23:51 +0200 > Stefan Agner wrote: > >> On 09.06.2018 07:52, Boris Brezillon wrote: >> > On Fri, 08 Jun 2018 23:51:01 +0200 >> > Stefan Agner wrote: >> > >> > >> >> > >> >> > void tegra_nand_controller_reset(struct

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 9 Jun 2018 08:41:57 +0200 Boris Brezillon wrote: > On Sat, 09 Jun 2018 08:23:51 +0200 > Stefan Agner wrote: > > > On 09.06.2018 07:52, Boris Brezillon wrote: > > > On Fri, 08 Jun 2018 23:51:01 +0200 > > > Stefan Agner wrote: > > > > > > > > >> > > > >> > void

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 9 Jun 2018 08:41:57 +0200 Boris Brezillon wrote: > On Sat, 09 Jun 2018 08:23:51 +0200 > Stefan Agner wrote: > > > On 09.06.2018 07:52, Boris Brezillon wrote: > > > On Fri, 08 Jun 2018 23:51:01 +0200 > > > Stefan Agner wrote: > > > > > > > > >> > > > >> > void

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 09 Jun 2018 08:23:51 +0200 Stefan Agner wrote: > On 09.06.2018 07:52, Boris Brezillon wrote: > > On Fri, 08 Jun 2018 23:51:01 +0200 > > Stefan Agner wrote: > > > > > >> > > >> > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) > >> > { > >> > int err; > >> > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Boris Brezillon
On Sat, 09 Jun 2018 08:23:51 +0200 Stefan Agner wrote: > On 09.06.2018 07:52, Boris Brezillon wrote: > > On Fri, 08 Jun 2018 23:51:01 +0200 > > Stefan Agner wrote: > > > > > >> > > >> > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) > >> > { > >> > int err; > >> > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Stefan Agner
On 09.06.2018 07:52, Boris Brezillon wrote: > On Fri, 08 Jun 2018 23:51:01 +0200 > Stefan Agner wrote: > > >> > >> > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) >> > { >> >int err; >> > >> >disable_irq(ctrl->irq); >> > >> >err =

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-09 Thread Stefan Agner
On 09.06.2018 07:52, Boris Brezillon wrote: > On Fri, 08 Jun 2018 23:51:01 +0200 > Stefan Agner wrote: > > >> > >> > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) >> > { >> >int err; >> > >> >disable_irq(ctrl->irq); >> > >> >err =

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Boris Brezillon
On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner wrote: > + > +static const struct of_device_id tegra_nand_of_match[] = { > + { .compatible = "nvidia,tegra20-nand" }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver tegra_nand_driver = { > + .driver = { > +

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Boris Brezillon
On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner wrote: > + > +static const struct of_device_id tegra_nand_of_match[] = { > + { .compatible = "nvidia,tegra20-nand" }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver tegra_nand_driver = { > + .driver = { > +

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Boris Brezillon
On Fri, 08 Jun 2018 23:51:01 +0200 Stefan Agner wrote: > > > > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) > > { > > int err; > > > > disable_irq(ctrl->irq); > > > > err = reset_control_reset(ctrl->rst); > > if (err) { > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Boris Brezillon
On Fri, 08 Jun 2018 23:51:01 +0200 Stefan Agner wrote: > > > > void tegra_nand_controller_reset(struct tegra_nand_controller *ctrl) > > { > > int err; > > > > disable_irq(ctrl->irq); > > > > err = reset_control_reset(ctrl->rst); > > if (err) { > >

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Stefan Agner
On 01.06.2018 11:20, Dmitry Osipenko wrote: > On 01.06.2018 01:16, Stefan Agner wrote: >> Add support for the NAND flash controller found on NVIDIA >> Tegra 2 SoCs. This implementation does not make use of the >> command queue feature. Regular operations/data transfers are >> done in PIO mode.

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-08 Thread Stefan Agner
On 01.06.2018 11:20, Dmitry Osipenko wrote: > On 01.06.2018 01:16, Stefan Agner wrote: >> Add support for the NAND flash controller found on NVIDIA >> Tegra 2 SoCs. This implementation does not make use of the >> command queue feature. Regular operations/data transfers are >> done in PIO mode.

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-04 Thread Stefan Agner
Hi Randolph, On 04.06.2018 19:16, Randolph Maaßen wrote: > Am Freitag, den 01.06.2018, 00:16 +0200 schrieb Stefan Agner: >> Add support for the NAND flash controller found on NVIDIA >> Tegra 2 SoCs. This implementation does not make use of the >> command queue feature. Regular operations/data

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-04 Thread Stefan Agner
Hi Randolph, On 04.06.2018 19:16, Randolph Maaßen wrote: > Am Freitag, den 01.06.2018, 00:16 +0200 schrieb Stefan Agner: >> Add support for the NAND flash controller found on NVIDIA >> Tegra 2 SoCs. This implementation does not make use of the >> command queue feature. Regular operations/data

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-04 Thread Randolph Maaßen
Am Freitag, den 01.06.2018, 00:16 +0200 schrieb Stefan Agner: > Add support for the NAND flash controller found on NVIDIA > Tegra 2 SoCs. This implementation does not make use of the > command queue feature. Regular operations/data transfers are > done in PIO mode. Page read/writes with hardware

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-04 Thread Randolph Maaßen
Am Freitag, den 01.06.2018, 00:16 +0200 schrieb Stefan Agner: > Add support for the NAND flash controller found on NVIDIA > Tegra 2 SoCs. This implementation does not make use of the > command queue feature. Regular operations/data transfers are > done in PIO mode. Page read/writes with hardware

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-01 Thread Dmitry Osipenko
On 01.06.2018 01:16, Stefan Agner wrote: > Add support for the NAND flash controller found on NVIDIA > Tegra 2 SoCs. This implementation does not make use of the > command queue feature. Regular operations/data transfers are > done in PIO mode. Page read/writes with hardware ECC make > use of the

Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-06-01 Thread Dmitry Osipenko
On 01.06.2018 01:16, Stefan Agner wrote: > Add support for the NAND flash controller found on NVIDIA > Tegra 2 SoCs. This implementation does not make use of the > command queue feature. Regular operations/data transfers are > done in PIO mode. Page read/writes with hardware ECC make > use of the

[PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-31 Thread Stefan Agner
Add support for the NAND flash controller found on NVIDIA Tegra 2 SoCs. This implementation does not make use of the command queue feature. Regular operations/data transfers are done in PIO mode. Page read/writes with hardware ECC make use of the DMA for data transfer. Signed-off-by: Lucas Stach

[PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-31 Thread Stefan Agner
Add support for the NAND flash controller found on NVIDIA Tegra 2 SoCs. This implementation does not make use of the command queue feature. Regular operations/data transfers are done in PIO mode. Page read/writes with hardware ECC make use of the DMA for data transfer. Signed-off-by: Lucas Stach