Re: [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:44:47PM +0300, Sergey Suloev wrote: > As long as the completion is already provided by the SPI core > then there is no need to waste extra-memory on this. > Also a waiting function was added to avoid code duplication. This would need to be split in two patches, one to

Re: [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:44:47PM +0300, Sergey Suloev wrote: > As long as the completion is already provided by the SPI core > then there is no need to waste extra-memory on this. > Also a waiting function was added to avoid code duplication. This would need to be split in two patches, one to

[PATCH v3 4/6] spi: sun6i: use completion provided by SPI core

2018-04-03 Thread Sergey Suloev
As long as the completion is already provided by the SPI core then there is no need to waste extra-memory on this. Also a waiting function was added to avoid code duplication. Changes in v2: 1) Fixed issue with passing an invalid argument into devm_request_irq() function. Signed-off-by: Sergey

[PATCH v3 4/6] spi: sun6i: use completion provided by SPI core

2018-04-03 Thread Sergey Suloev
As long as the completion is already provided by the SPI core then there is no need to waste extra-memory on this. Also a waiting function was added to avoid code duplication. Changes in v2: 1) Fixed issue with passing an invalid argument into devm_request_irq() function. Signed-off-by: Sergey