RE: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-22 Thread Ghannam, Yazen
> -Original Message- > From: linux-edac-ow...@vger.kernel.org On > Behalf Of Borislav Petkov > Sent: Tuesday, May 21, 2019 6:09 PM > To: Luck, Tony > Cc: Ghannam, Yazen ; linux-e...@vger.kernel.org; > linux-kernel@vger.kernel.org; x...@kernel.org > Subject: Re

Re: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-21 Thread Borislav Petkov
On Tue, May 21, 2019 at 01:42:40PM -0700, Luck, Tony wrote: > On Tue, May 21, 2019 at 10:29:02PM +0200, Borislav Petkov wrote: > > > > Can we do instead: > > > > -static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank *, mce_banks_array); > > +static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank, > >

Re: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-21 Thread Luck, Tony
On Tue, May 21, 2019 at 10:29:02PM +0200, Borislav Petkov wrote: > > Can we do instead: > > -static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank *, mce_banks_array); > +static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank, > mce_banks_array[MAX_NR_BANKS]); > > which should be something like 9*32 =

Re: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-21 Thread Borislav Petkov
On Tue, May 21, 2019 at 05:52:42PM +, Ghannam, Yazen wrote: > This message comes from ___might_sleep() which checks the > system_state. > > On CPU0, system_state=SYSTEM_BOOTING. > > On every other CPU, system_state=SYSTEM_SCHEDULING, and that's the > only system_state where the message is

RE: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-21 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Saturday, May 18, 2019 6:26 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; b...@suse.de; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH v3 4/6] x86/MCE: Mak

Re: [PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-05-18 Thread Borislav Petkov
On Tue, Apr 30, 2019 at 08:32:20PM +, Ghannam, Yazen wrote: > From: Yazen Ghannam > > The number of MCA banks is provided per logical CPU. Historically, this > number has been the same across all CPUs, but this is not an > architectural guarantee. Future AMD systems may have MCA bank counts

[PATCH v3 4/6] x86/MCE: Make number of MCA banks per_cpu

2019-04-30 Thread Ghannam, Yazen
From: Yazen Ghannam The number of MCA banks is provided per logical CPU. Historically, this number has been the same across all CPUs, but this is not an architectural guarantee. Future AMD systems may have MCA bank counts that vary between logical CPUs in a system. This issue was partially