Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns()

2013-03-25 Thread David Howells
Lucas De Marchi wrote: > Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of > calling call_usermodehelper_fns(). In case there's an OOM in this last > function the cleanup function may not be called - in this case we would > miss a call to key_put(). > > Signed-off-by: Lucas

Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns()

2013-03-11 Thread James Morris
On Mon, 11 Mar 2013, Lucas De Marchi wrote: > Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of > calling call_usermodehelper_fns(). In case there's an OOM in this last > function the cleanup function may not be called - in this case we would > miss a call to key_put(). > >

[PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns()

2013-03-11 Thread Lucas De Marchi
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of calling call_usermodehelper_fns(). In case there's an OOM in this last function the cleanup function may not be called - in this case we would miss a call to key_put(). Signed-off-by: Lucas De Marchi --- Changes from v2: sim