Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Alan Stern
On Fri, 29 Mar 2013, Geoff Levand wrote: > Hi Alan, > > > Actually, I think this is not necessary. Instead those three glue > > files ought to be changed. They should not need to call > > ehci_shutdown() directly. > > I sent out a separate patch that removes the ehci_shutdown() > call in

Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Geoff Levand
Hi Alan, > Actually, I think this is not necessary. Instead those three glue > files ought to be changed. They should not need to call > ehci_shutdown() directly. I sent out a separate patch that removes the ehci_shutdown() call in ps3_ehci_remove(). I tested it by removing and installing the

Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Alan Stern
On Thu, 28 Mar 2013, Arnd Bergmann wrote: > The ehci_shutdown function is used by the platform specific ehci backends > for at91, tegra and ps3. In order to turn any of these into separate > modules, we need to make this function globally visible and export it. Actually, I think this is not

Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Alan Stern
On Thu, 28 Mar 2013, Arnd Bergmann wrote: The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Actually, I think this is not

Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Geoff Levand
Hi Alan, Actually, I think this is not necessary. Instead those three glue files ought to be changed. They should not need to call ehci_shutdown() directly. I sent out a separate patch that removes the ehci_shutdown() call in ps3_ehci_remove(). I tested it by removing and installing the

Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-29 Thread Alan Stern
On Fri, 29 Mar 2013, Geoff Levand wrote: Hi Alan, Actually, I think this is not necessary. Instead those three glue files ought to be changed. They should not need to call ehci_shutdown() directly. I sent out a separate patch that removes the ehci_shutdown() call in

[PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-28 Thread Arnd Bergmann
The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Signed-off-by: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc:

[PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-28 Thread Arnd Bergmann
The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan