Re: [PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config()

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:32PM +0800, David Wu wrote: > It is usually possible to configure the polarity, cycle and duty all at once, > so that the polarity and cycle and duty should be binding together. Move it > into rockchip_pwm_config(), as well as prepared for the next atomic update >

Re: [PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config()

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:32PM +0800, David Wu wrote: > It is usually possible to configure the polarity, cycle and duty all at once, > so that the polarity and cycle and duty should be binding together. Move it > into rockchip_pwm_config(), as well as prepared for the next atomic update >

[PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config()

2017-08-08 Thread David Wu
It is usually possible to configure the polarity, cycle and duty all at once, so that the polarity and cycle and duty should be binding together. Move it into rockchip_pwm_config(), as well as prepared for the next atomic update commit. Signed-off-by: David Wu ---

[PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config()

2017-08-08 Thread David Wu
It is usually possible to configure the polarity, cycle and duty all at once, so that the polarity and cycle and duty should be binding together. Move it into rockchip_pwm_config(), as well as prepared for the next atomic update commit. Signed-off-by: David Wu --- drivers/pwm/pwm-rockchip.c |