Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 15:27, Xiaoyao Li wrote: >> > > I'm ok with kvm_vcpu_after_set_cpuid(). > > BTW there is an unknown for me regarding enter_smm(). Currently, it > calls kvm_update_cpuid(). I'm not sure which part it really needs, > update CPUID or update vcpu state based on CPUID? It needs to update

Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Xiaoyao Li
On 7/8/2020 8:41 PM, Paolo Bonzini wrote: On 08/07/20 14:33, Xiaoyao Li wrote: On 7/8/2020 8:06 PM, Paolo Bonzini wrote: On 08/07/20 08:50, Xiaoyao Li wrote: Split the part of updating vcpu model out of kvm_update_cpuid(), and put it into a new kvm_update_vcpu_model(). So it's more clear that

Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 14:33, Xiaoyao Li wrote: > On 7/8/2020 8:06 PM, Paolo Bonzini wrote: >> On 08/07/20 08:50, Xiaoyao Li wrote: >>> Split the part of updating vcpu model out of kvm_update_cpuid(), and put >>> it into a new kvm_update_vcpu_model(). So it's more clear that >>> kvm_update_cpuid() is to

Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Xiaoyao Li
On 7/8/2020 8:06 PM, Paolo Bonzini wrote: On 08/07/20 08:50, Xiaoyao Li wrote: Split the part of updating vcpu model out of kvm_update_cpuid(), and put it into a new kvm_update_vcpu_model(). So it's more clear that kvm_update_cpuid() is to update guest CPUID settings, while

Re: [PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Paolo Bonzini
On 08/07/20 08:50, Xiaoyao Li wrote: > Split the part of updating vcpu model out of kvm_update_cpuid(), and put > it into a new kvm_update_vcpu_model(). So it's more clear that > kvm_update_cpuid() is to update guest CPUID settings, while > kvm_update_vcpu_model() is to update vcpu model

[PATCH v3 4/8] KVM: X86: Split kvm_update_cpuid()

2020-07-08 Thread Xiaoyao Li
Split the part of updating vcpu model out of kvm_update_cpuid(), and put it into a new kvm_update_vcpu_model(). So it's more clear that kvm_update_cpuid() is to update guest CPUID settings, while kvm_update_vcpu_model() is to update vcpu model (settings) based on the updated CPUID settings.