Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-13 Thread Bjorn Helgaas
On Mon, Jan 13, 2014 at 1:30 AM, Rajat Jain wrote: > Yinghai: I am trying to understand what exactly is this platform bug > and how to add a quirk such that this platform remains unaffected. Can > you please help me by suggesting how to decide if this is _the_ > platform that has the bug (the

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-13 Thread Rajat Jain
Hi Yinghai / Bjorn, On Thu, Jan 9, 2014 at 12:58 PM, Bjorn Helgaas wrote: >>> > >>> > On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain >>> > wrote: >>> > > Hello Bjorn, >>> > > >>> > > Just checking on the fate of this patch set... >>> > > >>> > > On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas >>>

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-13 Thread Rajat Jain
Hi Yinghai / Bjorn, On Thu, Jan 9, 2014 at 12:58 PM, Bjorn Helgaas bhelg...@google.com wrote: On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain rajatxj...@gmail.com wrote: Hello Bjorn, Just checking on the fate of this patch set... On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-13 Thread Bjorn Helgaas
On Mon, Jan 13, 2014 at 1:30 AM, Rajat Jain rajatxj...@gmail.com wrote: Yinghai: I am trying to understand what exactly is this platform bug and how to add a quirk such that this platform remains unaffected. Can you please help me by suggesting how to decide if this is _the_ platform that has

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-09 Thread Bjorn Helgaas
orn Helgaas; Rajat Jain >> Cc: Rajat Jain; Kenji Kaneshige; Alex Williamson; Yijing Wang; linux- >> p...@vger.kernel.org; linux-kernel@vger.kernel.org; Yinghai Lu; Guenter >> Roeck; Yinghai Lu >> Subject: RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, >>

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-09 Thread Rajat Jain
g Wang; linux- > p...@vger.kernel.org; linux-kernel@vger.kernel.org; Yinghai Lu; Guenter > Roeck; Yinghai Lu > Subject: RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, > during removal > > Hello Bjorn / Yinghai, > > > -Original Message- > &

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-09 Thread Rajat Jain
...@vger.kernel.org; linux-kernel@vger.kernel.org; Yinghai Lu; Guenter Roeck; Yinghai Lu Subject: RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal Hello Bjorn / Yinghai, -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] Sent: Monday

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-09 Thread Bjorn Helgaas
: Rajat Jain; Kenji Kaneshige; Alex Williamson; Yijing Wang; linux- p...@vger.kernel.org; linux-kernel@vger.kernel.org; Yinghai Lu; Guenter Roeck; Yinghai Lu Subject: RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal Hello Bjorn / Yinghai, -Original Message

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-07 Thread Rajat Jain
el.org; Yinghai Lu; Guenter > Roeck; Rajat Jain; Yinghai Lu > Subject: Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, > during removal > > On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain > wrote: > > Hello Bjorn, > > > > Just checking on the fate of

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-07 Thread Rajat Jain
; Guenter Roeck; Rajat Jain; Yinghai Lu Subject: Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain rajatxj...@gmail.com wrote: Hello Bjorn, Just checking on the fate of this patch set... On Tue, Dec 17, 2013 at 5:02

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-06 Thread Bjorn Helgaas
On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain wrote: > Hello Bjorn, > > Just checking on the fate of this patch set... > > On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas wrote: >> [+cc ying...@kernel.org (seems to be Yinghai's preferred email] >> >> On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-06 Thread Bjorn Helgaas
On Sun, Jan 5, 2014 at 10:53 AM, Rajat Jain rajatxj...@gmail.com wrote: Hello Bjorn, Just checking on the fate of this patch set... On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-05 Thread Rajat Jain
Hello Bjorn, Just checking on the fate of this patch set... On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas wrote: > [+cc ying...@kernel.org (seems to be Yinghai's preferred email] > > On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: >> We need future link up events for hot-add, thus

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2014-01-05 Thread Rajat Jain
Hello Bjorn, Just checking on the fate of this patch set... On Tue, Dec 17, 2013 at 5:02 PM, Bjorn Helgaas bhelg...@google.com wrote: [+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: We need future link up events for

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Yinghai Lu
On Tue, Dec 17, 2013 at 10:17 PM, Rajat Jain wrote: > Well, in that case I doubt if the patch will solve the problem. I think > Most likely the "card present / not present" messages may be replaced > By "link-up / link-down" messages. But I'd appreciate your testing. I did have a debug patch at

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
> -Original Message- > From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of > > On Tue, Dec 17, 2013 at 7:20 PM, Rajat Jain > wrote: > > > > Actually I did not understand the original problem and the solution in > > the first place (so I also do not understand how

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Yinghai Lu
On Tue, Dec 17, 2013 at 7:20 PM, Rajat Jain wrote: > > Actually I did not understand the original problem and the solution in the > first > place (so I also do not understand how might disabling of presence detect > notification > help). If you can give more details on the original problem that

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
nel.org; linux-kernel@vger.kernel.org; > y...@jasper.es > Subject: Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, > during removal > > On Wed, Dec 18, 2013 at 03:20:58AM +, Rajat Jain wrote: > > > > > > > -Original Message- > > > From

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Guenter Roeck
On Wed, Dec 18, 2013 at 03:20:58AM +, Rajat Jain wrote: > > > > -Original Message- > > From: Bjorn Helgaas [mailto:bhelg...@google.com] > > > > [+cc ying...@kernel.org (seems to be Yinghai's preferred email] > > > > On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: > > >

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > > [+cc ying...@kernel.org (seems to be Yinghai's preferred email] > > On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: > > We need future link up events for hot-add, thus don't disable the link > >

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Bjorn Helgaas
[+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: > We need future link up events for hot-add, thus don't disable > the link permanently during device removal. Also, remove the static > functions that are now left unused.

[PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
We need future link up events for hot-add, thus don't disable the link permanently during device removal. Also, remove the static functions that are now left unused. Signed-off-by: Rajat Jain Signed-off-by: Guenter Roeck --- v3: no change, created by splitting the patch v2 [2/4] v2: (non

[PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
We need future link up events for hot-add, thus don't disable the link permanently during device removal. Also, remove the static functions that are now left unused. Signed-off-by: Rajat Jain rajatj...@juniper.net Signed-off-by: Guenter Roeck gro...@juniper.net --- v3: no change, created by

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Bjorn Helgaas
[+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: We need future link up events for hot-add, thus don't disable the link permanently during device removal. Also, remove the static functions that are now left unused. The

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
-Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] [+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: We need future link up events for hot-add, thus don't disable the link permanently

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Guenter Roeck
On Wed, Dec 18, 2013 at 03:20:58AM +, Rajat Jain wrote: -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] [+cc ying...@kernel.org (seems to be Yinghai's preferred email] On Tue, Dec 17, 2013 at 12:06:05PM -0800, Rajat Jain wrote: We need future

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
@vger.kernel.org; y...@jasper.es Subject: Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal On Wed, Dec 18, 2013 at 03:20:58AM +, Rajat Jain wrote: -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] [+cc ying...@kernel.org (seems

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Yinghai Lu
On Tue, Dec 17, 2013 at 7:20 PM, Rajat Jain rajatj...@juniper.net wrote: Actually I did not understand the original problem and the solution in the first place (so I also do not understand how might disabling of presence detect notification help). If you can give more details on the

RE: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Rajat Jain
-Original Message- From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of On Tue, Dec 17, 2013 at 7:20 PM, Rajat Jain rajatj...@juniper.net wrote: Actually I did not understand the original problem and the solution in the first place (so I also do not

Re: [PATCH v3 4/8] pciehp: Don't disable the link permanently, during removal

2013-12-17 Thread Yinghai Lu
On Tue, Dec 17, 2013 at 10:17 PM, Rajat Jain rajatj...@juniper.net wrote: Well, in that case I doubt if the patch will solve the problem. I think Most likely the card present / not present messages may be replaced By link-up / link-down messages. But I'd appreciate your testing. I did have a