Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-03-05 Thread Leo Yan
Hi Arnaldo, On Fri, Mar 05, 2021 at 02:29:44PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > > From: Suzu

Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > From: Suzuki K Poulose > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongl

Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-02-08 Thread Leo Yan
On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > From: Suzuki K Poulose > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > takes these two values (14 and 28 prespectively) as bit masks, b

Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-02-08 Thread Mathieu Poirier
On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > From: Suzuki K Poulose > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > takes these two values (14 and 28 prespectively) as bit masks, but > actually both are the offset for bits. But this doesn't lead to > fur

[PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-02-06 Thread Leo Yan
From: Suzuki K Poulose When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly takes these two values (14 and 28 prespectively) as bit masks, but actually both are the offset for bits. But this doesn't lead to further failure due to the AND logic operation will be always true for E