Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28/10/2015 at 22:31:48 +0900, Krzysztof Kozlowski wrote : > > So you don't care about DT backward compatibility because when a > > workaround will be needed for one of the IPs, then you will have to > > update the old dtb to use it. > > Nope, DTB does not contain the name for RTC driver

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

W dniu 28.10.2015 o 19:30, Alim Akhtar pisze: > Hi Alexandre, > > On 10/28/2015 03:18 PM, Alexandre Belloni wrote: >> On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >>> The s2mps13 clock driver added new name and compatible... which was >>> probably totally unneeded (I missed that

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >>

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hi Alexandre, On 10/28/2015 03:18 PM, Alexandre Belloni wrote: On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : The s2mps13 clock driver added new name and compatible... which was probably totally unneeded (I missed that during review). We don't have to make this as a rule...

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : > The s2mps13 clock driver added new name and compatible... which was > probably totally unneeded (I missed that during review). We don't have > to make this as a rule... > > Since we do not have any data about future workarounds and

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >>

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

W dniu 28.10.2015 o 19:30, Alim Akhtar pisze: > Hi Alexandre, > > On 10/28/2015 03:18 PM, Alexandre Belloni wrote: >> On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >>> The s2mps13 clock driver added new name and compatible... which was >>> probably totally unneeded (I missed that

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28/10/2015 at 22:31:48 +0900, Krzysztof Kozlowski wrote : > > So you don't care about DT backward compatibility because when a > > workaround will be needed for one of the IPs, then you will have to > > update the old dtb to use it. > > Nope, DTB does not contain the name for RTC driver

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : > The s2mps13 clock driver added new name and compatible... which was > probably totally unneeded (I missed that during review). We don't have > to make this as a rule... > > Since we do not have any data about future workarounds and

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hi Alexandre, On 10/28/2015 03:18 PM, Alexandre Belloni wrote: On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : The s2mps13 clock driver added new name and compatible... which was probably totally unneeded (I missed that during review). We don't have to make this as a rule...

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 10/28/2015 09:01 AM, Krzysztof Kozlowski wrote: On 28.10.2015 12:14, Alim Akhtar wrote: Hello, On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: On 28.10.2015 10:53, Mark Brown wrote: On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: If that's true, then don't add

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28.10.2015 12:14, Alim Akhtar wrote: > Hello, > > On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: >> On 28.10.2015 10:53, Mark Brown wrote: >>> On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: >>> If that's true, then don't add new compatibles, new names etc.

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hello, On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: On 28.10.2015 10:53, Mark Brown wrote: On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: If that's true, then don't add new compatibles, new names etc. Re-use. No new code needed, no changes needed. Keep it simple.

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28.10.2015 10:53, Mark Brown wrote: > On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: > >> If that's true, then don't add new compatibles, new names etc. Re-use. >> No new code needed, no changes needed. Keep it simple. > > Well, it depends - it can be useful to get the

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: > If that's true, then don't add new compatibles, new names etc. Re-use. > No new code needed, no changes needed. Keep it simple. Well, it depends - it can be useful to get the information about it being a different part into

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 26.10.2015 21:51, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar > --- > drivers/rtc/rtc-s5m.c | 14 +- > 1 file changed, 13 insertions(+), 1

Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote : > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar One really small nitpick below else you can add my Acked-by: Alexandre Belloni >

Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote : > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar One really small nitpick below else you can add my Acked-by:

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 26.10.2015 21:51, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar > --- > drivers/rtc/rtc-s5m.c | 14 +- > 1 file changed, 13

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: > If that's true, then don't add new compatibles, new names etc. Re-use. > No new code needed, no changes needed. Keep it simple. Well, it depends - it can be useful to get the information about it being a different part into

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28.10.2015 10:53, Mark Brown wrote: > On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: > >> If that's true, then don't add new compatibles, new names etc. Re-use. >> No new code needed, no changes needed. Keep it simple. > > Well, it depends - it can be useful to get the

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 28.10.2015 12:14, Alim Akhtar wrote: > Hello, > > On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: >> On 28.10.2015 10:53, Mark Brown wrote: >>> On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: >>> If that's true, then don't add new compatibles, new names etc.

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hello, On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: On 28.10.2015 10:53, Mark Brown wrote: On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: If that's true, then don't add new compatibles, new names etc. Re-use. No new code needed, no changes needed. Keep it simple.

Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 10/28/2015 09:01 AM, Krzysztof Kozlowski wrote: On 28.10.2015 12:14, Alim Akhtar wrote: Hello, On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: On 28.10.2015 10:53, Mark Brown wrote: On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: If that's true, then don't add

[PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

RTC found in s2mps15 is almost same as one found in s2mps14. This patch add required changes to enable s2mps15 rtc timer. Signed-off-by: Alim Akhtar --- drivers/rtc/rtc-s5m.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-s5m.c

[PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

RTC found in s2mps15 is almost same as one found in s2mps14. This patch add required changes to enable s2mps15 rtc timer. Signed-off-by: Alim Akhtar --- drivers/rtc/rtc-s5m.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git