Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-28 Thread Wolfram Sang
On Wed, Jun 28, 2017 at 01:57:01PM +0300, Andy Shevchenko wrote: > On Wed, Jun 28, 2017 at 12:37 PM, Wolfram Sang wrote: > > > >> Not a chance! Where is the commit message? > > > > Don't you think $subject is clear enough? > > I would add the comment at least on how the output is changed since >

Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-28 Thread Andy Shevchenko
On Wed, Jun 28, 2017 at 12:37 PM, Wolfram Sang wrote: > >> Not a chance! Where is the commit message? > > Don't you think $subject is clear enough? I would add the comment at least on how the output is changed since pr_*("%s:"..., i2c->adap.name,...) to dev_*(&pdev->dev, ...) replacement. -- W

Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-28 Thread Wolfram Sang
> Not a chance! Where is the commit message? Don't you think $subject is clear enough? signature.asc Description: PGP signature

Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-28 Thread Andy Shevchenko
On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham wrote: On the first glance I have thought this is _the_ only patch that doesn't make my eyes hurt. Not a chance! Where is the commit message? Code below though looks fine. > @@ -107,8 +107,8 @@ static int i2c_pca_pf_waitforcompletion(void *pd) >

Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-27 Thread Wolfram Sang
On Mon, Jun 26, 2017 at 12:44:34PM +1200, Chris Packham wrote: > Signed-off-by: Chris Packham Applied to for-next, thanks! signature.asc Description: PGP signature

[PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

2017-06-25 Thread Chris Packham
Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-pca-platform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c index 7db481cbf402..395eca0cbb1f 100644 --- a/drivers/i2c/busses/i2c-pca-