Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-06 Thread Yang, Bin
On Tue, 2018-09-04 at 18:52 +0200, Thomas Gleixner wrote: > On Tue, 4 Sep 2018, Thomas Gleixner wrote: > > On Tue, 4 Sep 2018, Yang, Bin wrote: > > > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > > > @@ -625,6 +625,7 @@

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-06 Thread Yang, Bin
On Tue, 2018-09-04 at 18:52 +0200, Thomas Gleixner wrote: > On Tue, 4 Sep 2018, Thomas Gleixner wrote: > > On Tue, 4 Sep 2018, Yang, Bin wrote: > > > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > > > @@ -625,6 +625,7 @@

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Thomas Gleixner
On Tue, 4 Sep 2018, Thomas Gleixner wrote: > On Tue, 4 Sep 2018, Yang, Bin wrote: > > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > > > address, > > > > > >

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Thomas Gleixner
On Tue, 4 Sep 2018, Thomas Gleixner wrote: > On Tue, 4 Sep 2018, Yang, Bin wrote: > > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > > > address, > > > > > >

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Thomas Gleixner
On Tue, 4 Sep 2018, Yang, Bin wrote: > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > > address, > > > > > > psize = page_level_size(level); > > > pmask =

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Thomas Gleixner
On Tue, 4 Sep 2018, Yang, Bin wrote: > On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > > On Tue, 21 Aug 2018, Bin Yang wrote: > > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > > address, > > > > > > psize = page_level_size(level); > > > pmask =

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Yang, Bin
On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > On Tue, 21 Aug 2018, Bin Yang wrote: > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > address, > > > > psize = page_level_size(level); > > pmask = page_level_mask(level); > > + addr = address &

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-04 Thread Yang, Bin
On Tue, 2018-09-04 at 00:27 +0200, Thomas Gleixner wrote: > On Tue, 21 Aug 2018, Bin Yang wrote: > > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > > address, > > > > psize = page_level_size(level); > > pmask = page_level_mask(level); > > + addr = address &

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-03 Thread Thomas Gleixner
On Tue, 21 Aug 2018, Bin Yang wrote: > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > address, > > psize = page_level_size(level); > pmask = page_level_mask(level); > + addr = address & pmask; > > /* >* Calculate the number of pages,

Re: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-09-03 Thread Thomas Gleixner
On Tue, 21 Aug 2018, Bin Yang wrote: > @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long > address, > > psize = page_level_size(level); > pmask = page_level_mask(level); > + addr = address & pmask; > > /* >* Calculate the number of pages,

[PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-08-20 Thread Bin Yang
If there is a large page which contains an area which requires a different mapping that the one which the large page provides, then something went wrong _before_ this code is called. Here we can catch a case where the existing mapping is wrong already. Inspired-by: Thomas Gleixner

[PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-08-20 Thread Bin Yang
If there is a large page which contains an area which requires a different mapping that the one which the large page provides, then something went wrong _before_ this code is called. Here we can catch a case where the existing mapping is wrong already. Inspired-by: Thomas Gleixner