On 03.03.2021 11:31:10, Dario Binacchi wrote:
> I think these features need to be developed in a later series.
> I would stay with the extension to 64 messages equally divided
> between reception and transmission.
Fine with me.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde
Hi Marc,
> Il 03/03/2021 10:00 Marc Kleine-Budde ha scritto:
>
>
> On 03.03.2021 09:23:13, Dario Binacchi wrote:
> [...]
> > > > @@ -1205,17 +1203,31 @@ static int c_can_close(struct net_device *dev)
> > > > return 0;
> > > > }
> > > >
> > > > -struct net_device
, Alexander Stein
> > , Dario Binacchi
> > , "David S. Miller" , Jakub
> > Kicinski , Marc Kleine-Budde , Oliver
> > Hartkopp , Vincent Mailhol
> > , Wolfgang Grandegger ,
> > YueHaibing , Zhang Qilong
> > , linux-...@vger.kernel.org,
&g
On 03.03.2021 09:23:13, Dario Binacchi wrote:
[...]
> > > @@ -1205,17 +1203,31 @@ static int c_can_close(struct net_device *dev)
> > > return 0;
> > > }
> > >
> > > -struct net_device *alloc_c_can_dev(void)
> > > +struct net_device *alloc_c_can_dev(int msg_obj_num)
> > > {
> > > struct
ki , Marc Kleine-Budde , Oliver
> Hartkopp , Vincent Mailhol
> , Wolfgang Grandegger ,
> YueHaibing , Zhang Qilong
> , linux-...@vger.kernel.org,
> net...@vger.kernel.org
> Subject: [PATCH v3 5/6] can: c_can: prepare to up the message objects number
> X-Mailer: git-send-email 2.17.1
On 3/2/21 11:50 AM, Dario Binacchi wrote:
> Hi Marc,
>
>> Il 01/03/2021 20:45 Marc Kleine-Budde ha scritto:
>>
>>
>> On 01.03.2021 18:21:42, Dario Binacchi wrote:
> @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> while ((idx = ffs(pend))) {
>
Hi Marc,
> Il 01/03/2021 20:45 Marc Kleine-Budde ha scritto:
>
>
> On 01.03.2021 18:21:42, Dario Binacchi wrote:
> > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > > while ((idx = ffs(pend))) {
> > > > idx--;
> > > > pend
On 01.03.2021 18:21:42, Dario Binacchi wrote:
> > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > while ((idx = ffs(pend))) {
> > > idx--;
> > > pend &= ~(1 << idx);
> > > - obj = idx + C_CAN_MSG_OBJ_TX_FIRST;
> > > + obj = idx +
On 01.03.2021 14:08:45, Marc Kleine-Budde wrote:
> On 01.03.2021 12:38:05, Marc Kleine-Budde wrote:
> > On 28.02.2021 11:38:54, Dario Binacchi wrote:
> > [...]
> >
> > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > while ((idx = ffs(pend))) {
> > > idx--;
On 01.03.2021 18:24:31, Dario Binacchi wrote:
> Hi Marc,
>
> > Il 01/03/2021 14:08 Marc Kleine-Budde ha scritto:
> >
> >
> > On 01.03.2021 12:38:05, Marc Kleine-Budde wrote:
> > > On 28.02.2021 11:38:54, Dario Binacchi wrote:
> > > [...]
> > >
> > > > @@ -730,7 +728,7 @@ static void
Hi Marc,
> Il 01/03/2021 14:08 Marc Kleine-Budde ha scritto:
>
>
> On 01.03.2021 12:38:05, Marc Kleine-Budde wrote:
> > On 28.02.2021 11:38:54, Dario Binacchi wrote:
> > [...]
> >
> > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > > while ((idx = ffs(pend))) {
>
Hi Marc,
> Il 01/03/2021 12:38 Marc Kleine-Budde ha scritto:
>
>
> On 28.02.2021 11:38:54, Dario Binacchi wrote:
> [...]
>
> > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > while ((idx = ffs(pend))) {
> > idx--;
> > pend &= ~(1 << idx);
>
On 01.03.2021 12:38:05, Marc Kleine-Budde wrote:
> On 28.02.2021 11:38:54, Dario Binacchi wrote:
> [...]
>
> > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> > while ((idx = ffs(pend))) {
> > idx--;
> > pend &= ~(1 << idx);
> > - obj =
On 28.02.2021 11:38:54, Dario Binacchi wrote:
[...]
> @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev)
> while ((idx = ffs(pend))) {
> idx--;
> pend &= ~(1 << idx);
> - obj = idx + C_CAN_MSG_OBJ_TX_FIRST;
> + obj = idx +
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access")
the "driver casts the 16 message objects in stone, which is completely
braindead as contemporary hardware has up to 128 message objects".
The patch prepares the module to extend the number of message objects
beyond the 32
15 matches
Mail list logo
