Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-17 Thread Jernej Škrabec
Dne četrtek, 17. oktober 2019 ob 11:28:00 CEST je Maxime Ripard napisal(a): > Hi, > > I have a small comment that can definitely be addressed in a subsequent > patch > On Wed, Oct 16, 2019 at 09:28:06PM +0200, Jernej Skrabec wrote: > > + dev->bus_clk = devm_clk_get(dev->dev, "bus"); > > + if

Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-17 Thread Jernej Škrabec
Dne četrtek, 17. oktober 2019 ob 09:51:28 CEST je Hans Verkuil napisal(a): > On 10/16/19 9:28 PM, Jernej Skrabec wrote: > > Allwinner H3 SoC contains deinterlace unit, which has several modes of > > operation - bypass, weave, bob and mixed (advanced) mode. I don't know > > how mixed mode works,

Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-17 Thread Maxime Ripard
Hi, I have a small comment that can definitely be addressed in a subsequent patch On Wed, Oct 16, 2019 at 09:28:06PM +0200, Jernej Skrabec wrote: > + dev->bus_clk = devm_clk_get(dev->dev, "bus"); > + if (IS_ERR(dev->bus_clk)) { > + dev_err(dev->dev, "Failed to get bus

Re: [PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-17 Thread Hans Verkuil
On 10/16/19 9:28 PM, Jernej Skrabec wrote: > Allwinner H3 SoC contains deinterlace unit, which has several modes of > operation - bypass, weave, bob and mixed (advanced) mode. I don't know > how mixed mode works, but according to Allwinner it gives best results, > so they use it exclusively.

[PATCH v3 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-16 Thread Jernej Skrabec
Allwinner H3 SoC contains deinterlace unit, which has several modes of operation - bypass, weave, bob and mixed (advanced) mode. I don't know how mixed mode works, but according to Allwinner it gives best results, so they use it exclusively. Currently this mode is also hardcoded here. For each