Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

2014-06-04 Thread Venkatesh Srinivas
On 6/4/14, Paolo Bonzini wrote: > Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto: >> Do you really want to poll the request VQs for completions if the TMF >> was rejected? > > I wasn't sure, but bugs in this path are hard enough that I preferred > the safer patch. Ok. As long as it was delibe

Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto: Do you really want to poll the request VQs for completions if the TMF was rejected? I wasn't sure, but bugs in this path are hard enough that I preferred the safer patch. TMF ABORT may return FUNCTION REJECTED if the command to abort compl

Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

2014-06-04 Thread Venkatesh Srinivas
On 6/4/14, Paolo Bonzini wrote: > Even though the virtio-scsi spec guarantees that all requests related > to the TMF will have been completed by the time the TMF itself completes, > the request queue's callback might not have run yet. This causes requests > to be completed more than once, and as

[PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

2014-06-04 Thread Paolo Bonzini
Even though the virtio-scsi spec guarantees that all requests related to the TMF will have been completed by the time the TMF itself completes, the request queue's callback might not have run yet. This causes requests to be completed more than once, and as a result triggers a variety of BUGs or oo