Re: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI

2020-05-24 Thread Greg KH
On Mon, May 18, 2020 at 01:03:59PM -0700, Bhaumik Bhatt wrote: > +void mhi_create_debugfs(struct mhi_controller *mhi_cntrl) > +{ > + if (IS_ERR_OR_NULL(mhi_debugfs_root)) > + return; Why? Should not matter. > + mhi_cntrl->debugfs_dentry = > + debugfs_creat

[PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI

2020-05-18 Thread Bhaumik Bhatt
Introduce debugfs entries to show state, register, channel, and event ring information. Add MHI state counters to keep track of the state changes on the device. Also, allow the host to trigger a device reset, issue bus or device votes, and change the MHI timeout to help in debug. Signed-off-by: Bh