Re: [PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:24:29) > One thing to note is that we still want this space to be mappable by > userspace applications via /dev/mem, so we need to make sure that > there's no weird memory type mismatch that causes problems with that. > Adding Aaron to see if he has any concerns

Re: [PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap()

2018-08-09 Thread Julius Werner
One thing to note is that we still want this space to be mappable by userspace applications via /dev/mem, so we need to make sure that there's no weird memory type mismatch that causes problems with that. Adding Aaron to see if he has any concerns here, since I think he's seen something like that i

[PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap()

2018-08-09 Thread Stephen Boyd
This is all system memory, so we shouldn't be mapping this all with ioremap() as these aren't I/O regions. Instead, they're memory regions so we should use memremap(). Pick MEMREMAP_WB so we can map memory from RAM directly if that's possible, otherwise it falls back to ioremap_cache() like is bein